Closed Bug 1331907 Opened 7 years ago Closed 6 years ago

When first creating a popup window it don't go to the right place.

Categories

(WebExtensions :: Frontend, defect, P3)

53 Branch
defect

Tracking

(Not tracked)

RESOLVED INACTIVE

People

(Reporter: oinkandstuff, Assigned: bsilverberg)

Details

(Whiteboard: triaged)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36

Steps to reproduce:

Updating a Window of the type Popup with: chrome.windows.update left right Width height


Actual results:

The window goes everywhere wrong places. 
In Google Chrome it works just right, but in firefox the position and size of the window is not ok.


Expected results:

It should behave like Google Chrome Popup window and position and dimension the window with the right places/size.
Flags: needinfo?(kmaglione+bmo)
Whiteboard: investigation
Flags: needinfo?(kmaglione+bmo) → needinfo?(bob.silverberg)
I've done some preliminary testing of this, using the existing test for windows.update at [1]. I have found, on both OS X and Windows, that calling windows.update on a popup window and changing the size and location of the window does work as expected, at least according to this test. 

I did, however, find that creating a popup window in a specific location does not create the window in the expected location, according to this test, but perhaps the expectations in the test need to be altered when dealing with a popup window.

Right now the test is creating a window with {left: 100, top: 100, width: 500, height: 300}, but the actual popup window that is created has {"top":365,"left":710,"width":500,"height":300}.

As I say above, perhaps this is expected with a popup, as maybe the location we specify is used with a different offset, but regardless of that potential issue, I did not find any issues with calling windows.update on a popup window.

oinkandstuff, can you provide some more information about how to reproduce the problem you are seeing? On which platform are you running Firefox, and which version of Firefox? Can you attach a sample extension that demonstrates this issue?

[1] http://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_windows_size.js
Flags: needinfo?(bob.silverberg) → needinfo?(oinkandstuff)
webextensions: --- → ?
webextensions: ? → ---
The issue that I reported looks fixed now but what Bob Silverberg [:bsilverberg] said may be true. When first creating a popup window it don't go to the right place.
Flags: needinfo?(oinkandstuff)
changed name to reflect comment 2
Assignee: nobody → bob.silverberg
Priority: -- → P3
Summary: chrome.windows.update left right Width height don't place the window in the right place → When first creating a popup window it don't go to the right place.
Whiteboard: investigation → triaged
I'm not sure what the status of this bug is, tbh. The original reported says (in comment 2) that what they originally reported is no longer happening, but there is a reference to a comment I made about the test. 

I wasn't reporting a bug, per se, just an observation (in comment 1) that, according to the test (which I changed to test a popup window), creating a popup window in a specific location does not create the window in the expected location. But that may just be because the expectation set by the test is not correct.

Unless we are concerned about my observation about the test, this can be closed. Kris, do you have any opinions on this?
Flags: needinfo?(kmaglione+bmo)
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
Product: Toolkit → WebExtensions
Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.