1332240 - Perma failure in TEST-UNEXPECTED-FAIL | js1_8_5/extensions/dataview.js | (args: "") when trunk moves to aurora 53

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Carsten Book [:Tomcat]]

TEST-UNEXPECTED-FAIL | js1_8_5/extensions/dataview.js | (args: "")

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8644d251d430095b60f10b6e7ad20f5b51b58568

[task 2017-01-19T09:46:48.198970Z] BUGNUMBER: 575688

[task 2017-01-19T09:46:48.198982Z] STATUS: DataView tests

[task 2017-01-19T09:46:48.199007Z] js1_8_5/extensions/dataview.js:57:6 ReferenceError: SharedArrayBuffer is not defined

[task 2017-01-19T09:46:48.199018Z] Stack:

[task 2017-01-19T09:46:48.199036Z]   bufferize@js1_8_5/extensions/dataview.js:57:6

[task 2017-01-19T09:46:48.199052Z]   test@js1_8_5/extensions/dataview.js:73:14

[task 2017-01-19T09:46:48.199068Z]   @js1_8_5/extensions/dataview.js:1652:1

[task 2017-01-19T09:46:48.199089Z] TEST-UNEXPECTED-FAIL | js1_8_5/extensions/dataview.js | (args: "")

Comment 1

[Carsten Book [:Tomcat]]

[Tracking Requested - why for this release]:

Comment 2

[Carsten Book [:Tomcat]]

note: requested blocking because this might cause tree closure after merge day , since this was found by uplift simulations for running trunk as aurora

Comment 3

[Lars T Hansen [:lth]]

The test is easily fixed but it's exceptionally troubling that this happens when trunk is uplifted as aurora, as this feature should be enabled on aurora.

Comment 4

[Lars T Hansen [:lth]]

This is a problem primarily with the test case and secondarily with the JS shell.  The problem is that the shell has its own notion of when shared memory and atomics are enabled by default, and that notion is "nightly only", which is not in sync with Firefox and hence the bug in the test case was exposed here.

This test would not have failed had it been run in the browser (though it would fail in beta :)

Comment 5

[Lars T Hansen [:lth]]

Attachment: bug1332240-guard-test.patch

Add a guard to the test case to check for availability of SharedArrayBuffer.

Comment 6

[Lars T Hansen [:lth]]

Attachment: bug1332240-enable-sab.patch

Enable SAB+Atomics by default in the shell, they can be turned off using a shell argument.

I can't think of a reason why we should be tracking Firefox here, but we could do so, by changing the #ifdef instead of removing it as I do.  (SAB+Atomics are enabled by default in Firefox Nightly and Aurora builds only.)

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8828283 [details] [diff] [review]
bug1332240-enable-sab.patch

Review of attachment 8828283 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I'd really prefer to be in sync with Firefox; istr fuzzers test beta/release shells too (?), and there might issues when patches are non being uplifted.

rs=me for doing that.

Comment 8

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb476a85015b45db1e8bcd45439c7767dcfa13a1
Bug 1332240 - Properly guard a test case on SharedArrayBuffer. r=bbouvier

Comment 9

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43b1b5c5d5d00ebf624d8de9c7d5ef030394e899
Bug 1332240 - Enable SharedArrayBuffer and Atomics by default in JS shell also for Aurora. r=bbouvier

Comment 10

[Marcia Knous [:marcia]]

Tracking 53+ for this issue.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb476a85015b
https://hg.mozilla.org/mozilla-central/rev/43b1b5c5d5d0