1332431 - Address failures to commit/purge various SharedPreferences used by Sync

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Android Sync, defect, P3)

Description

[:Grisha Kruglov]

It's possible that our attempts to reset collections' last-synced timestamps and stage-specific persisted repository state (introduced in Bug 1291821) will fail. We're persisting via SharedPreferences.Editor's commit call, which might fail due to various I/O issues. This is supposed to be rare, very rare, but most of our code using `commit` never checks for failures.

In case of un-purged timestamps and/or repository state, unwanted side-effects largely include incorrect are missing records on consequent syncs

One way to address this in a context of sync is to further prefix PrefsBranch with syncID and probably current clientID, which should help limit negative impact of any state that might linger past its lifetime.

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.