1332567 - Make it faster to serialize layer attribute changes

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

It's slow to serialize CommonLayerAttributes when there are many layers. We can improve it by grouping trivially serializable attributes together. The more types of fields we can group together like this, the easier it will be to eliminate expensive deserialization on the compositor side as well.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, move ScrollDirection

Move ScrollDirection LayersTypes.h and give it a proper enum class type.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, don't use TransformMatrix

No reason to use this union wrapper in CommonLayerAttributes.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 3, lump Paint operations separately

This lets us easily serialize stuff between Edits and Paints, which must come last.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 4, lump OpSetLayerAttributes separately

This splits OpSetLayerAttributes out of Edit. Since it's a huge struct, this will reduce the amount of memory traffic needed when building the transaction message.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 5, factor out plain-old-data attributes

This moves plain-old-data attributes into a SimpleLayerAttributes class, with the goal that it can just be memcpy'd rather than serialized field-by-field.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 6, send simple attributes separately

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91bff1c46801
Move ScrollDirection to LayersTypes.h and make it a proper enum. (bug 1332567 part 1, r=kats)
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9befbf971c2
Don't use TransformMatrix in CommonLayerAttributes. (bug 1332567 part 2, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a4b81fa3f07
Lump Paint operations separately from Edit operations. (bug 1332567 part 3, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/485841a2f637
Move OpSetLayerAttributes out of the Edit vector. (bug 1332567 part 4, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/810b96fdc671
Factor POD attributes of Layers into a SimpleLayerAttributes class. (bug 1332567 part 5, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/44f9535628fd
Send SimpleLayerAttributes separately from CommonLayerAttributes. (bug 1332567 part 6, r=mattwoodrow)

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/91bff1c46801
https://hg.mozilla.org/mozilla-central/rev/e9befbf971c2
https://hg.mozilla.org/mozilla-central/rev/3a4b81fa3f07
https://hg.mozilla.org/mozilla-central/rev/485841a2f637
https://hg.mozilla.org/mozilla-central/rev/810b96fdc671
https://hg.mozilla.org/mozilla-central/rev/44f9535628fd