1332578 - Caching info. on items from frame tree or DOM-tree may improve performance of painting

Status: RESOLVED WONTFIX

(Core :: Web Painting, defect)

Description

[Thinker Li [:sinker]]

When doing ProcessDisplayItems(), it would be forced to collect information from frame tree, styles, and nsIContent for every items.  It is wasting time to access these memory and hurts CPU cache.  The idea is to keep a copy of key information on items to reduce the overhead of memory access.

Comment 1

[Thinker Li [:sinker]]

Attachment: getbounds.diff

This patch caches the result of GetBounds() when items are wrapped by nsDisplayWrapList.  This is just an experiment, not a best choice.  The best choice is to cache the result when create items to get benefited by the fact that the relative data is already in CPU cache.  Anyway, it shows an improvement of 5% on nsDisplayList::PaintRoot().

Comment 2

[Thinker Li [:sinker]]

Attachment: without-docacheforitems.diff

try this patch basing on getbounds.diff.  Although getbounds.diff improves |PaintRoot()|, but it increases |nsIFrame::BuildDisplayListForStackingContext()|.  This patch removes doing caching in |nsDisplayWrapList|, but do it for the first time that GetBoundsCache() has been called.

Comment 3

[(no longer active)]

Thinker, are you still working on this?

Comment 4

[Thinker Li [:sinker]]

I have some bugs relating to this one.  They should block this one.
I will do it later.

Comment 5

[Mayank Bansal]

dupe of Retain-DL ?