Closed
Bug 1332772
Opened 7 years ago
Closed 7 years ago
Baldr: tweak memory/table limits
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
|
6.74 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
This patch reflects updated thinking on limits (soon to be in v8) that only the *initial* memory/table lengths should be clamped. The maximums can be anything since these are just best-effort reservations that don't trigger failure.
Attachment #8828997 -
Flags: review?(bbouvier)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8828997 [details] [diff] [review] tweak-limits Review of attachment 8828997 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense, thanks. ::: js/src/wasm/WasmValidate.cpp @@ -932,5 @@ > return false; > > CheckedInt<uint32_t> initialBytes = memory.initial; > initialBytes *= PageSize; > - if (!initialBytes.isValid() || initialBytes.value() > uint32_t(INT32_MAX)) (yay, one fewer raw magical constant!)
Attachment #8828997 -
Flags: review?(bbouvier) → review+
Pushed by lwagner@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e24ae48855ba Baldr: tweak memory/table limits (r=bbouvier)
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e24ae48855ba
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•