1332945 - Run mochitest-browser-screenshots on Windows 10

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Matthew N. [:MattN]]

We should get screenshot coverage on Windows 10.

I did a try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7a34454c5f6ede0c8cdd17e87bc98f069e547d2&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=71005661 and it ran fine but all of the screenshots were solid black so this probably depends on getting the Windows 10 VMs ready for Tier 1.

Comment 1

[Armen [:armenzg]]

This is probably a dupe of bug 1343580.

Comment 2

[Matthew N. [:MattN]]

This depends on bug 1343580 to fix the black screenshots but we'll still need to schedule M(ss) on Win10.

Comment 3

[Pete Moore [:pmoore][:pete]]

There is a workaround for this now, described in: https://bugzilla.mozilla.org/show_bug.cgi?id=1343580#c6

Comment 4

[Rob Thijssen [:grenade (EET/UTC+0300)]]

these were enabled but seem to have stopped working. last run was here:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=2e7c10a9b86e30691f67855f6c8f98d984508d7c&filter-searchStr=mochitest-browser-screenshots

Comment 5

[Matthew N. [:MattN]]

I see them running fine now at tier 3 though I didn't confirm that the results are sane.

Johann, any chance you want to go through each image and make sure it's showing the correct thing?

Push for the analysis tools to support windows10: https://github.com/mnoorenberghe/mozscreenshots/commit/d2b206a92dce99bf953b7aadd559c13923761bfc

Comment 6

[Johann Hofmann [:johannh]]

Absolutely!

Comment 7

[Johann Hofmann [:johannh]]

I think we can close this as resolved, we've filed bugs 1373563, 1373178 and 1373551 to deal with the intermittent comparison issues, but it's definitely running on Windows 10 now and generally doing the correct thing.

Thanks!