Closed
Bug 1333460
Opened 7 years ago
Closed 7 years ago
add BUG_COMPONENT to ipc/* files
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
3.92 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
I do wonder about hal/*, as far as I can tell, this is all related to FirefoxOS bugzilla components, so I suspect this isn't Core::IPC. for glue/*, I see a mix of previous bugs touching these files, Core::IPC, DOM::Content Processes, Core:MFBT, etc., mostly I see Core::IPC, so I assume this is correct. for dbus/*, I see a lot of FirefoxOS again as well as some Dom:Device_Interfaces. Here is am not sure what to do. for contentproc/* I see a handful of Security::* bugs touching the one file for chromium/*, I see all Core::IPC in related bugs. for app/*, I see a big mix of components, most seem to be Core::IPC, although I suspect I am wrong for netd/*, I only see FirefoxOS components, I am not sure what to do here. for ril/*, I see almost all FirefoxOS components. for testshell/*, I see mostly Core::IPC, but a bit of Core::XPConnect. for unixfd/*, I only see FirefoxOS components. for unixsocket/* I only see FirefoxOS::* components.
Assignee | ||
Comment 1•7 years ago
|
||
:billm, a lot of this looks to be firefoxOS related code, can you confirm it is code to be deleted, or what component we should associate these source/test files with. Also any other confirmation or corrections on my above assertions about mappings to bugzilla components would be much appreciated.
Flags: needinfo?(wmccloskey)
glue: Core::IPC contentproc: Core::IPC chrome: Core::IPC app: DOM::Content Process testshell: Core::XPConnect is probably the closest component mscom: DOM::Accessibility ipdl: Core::IPC dbus, hal, netd, ril, unixfd, and unixsocket are all b2g as far as I know.
Flags: needinfo?(wmccloskey)
Assignee | ||
Comment 3•7 years ago
|
||
thanks for the quick reply- I have built a patch that should do what you recommended. ./mach file-info bugzilla-component ipc/** Core :: DOM: Content Processes ipc/app Core :: Disability Access APIs ipc/mscom Core :: IPC ipc/chromium ipc/contentproc ipc/glue ipc/ipdl ipc/moz.build ipc/pull-chromium.py Core :: XPConnect ipc/testshell Firefox OS :: General ipc/dbus ipc/hal ipc/netd ipc/ril ipc/unixfd ipc/unixsocket of course going into subdirs maintains the same level mapping.
Attachment #8830012 -
Flags: review?(wmccloskey) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7a0ae2c636d7 add BUG_COMPONENT to ipc/* files. r=billm
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7a0ae2c636d7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•