1334081 - [Static Analysis][Dereference before null check] In function EventSourceImpl::StreamReaderFunc

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that a dereference before null check happens in the following context:

>>  thisObject->AssertIsOnTargetThread();
>>  EventSourceImpl* thisObject = static_cast<EventSourceImpl*>(aClosure);
>>  if (!thisObject || !aWriteCount) {
>>    NS_WARNING("EventSource cannot read from stream: no aClosure or aWriteCount");
>>    return NS_ERROR_FAILURE;
>>  }
>>  thisObject->ParseSegment((const char*)aFromRawSegment, aCount);

Even though we could assume that the entry parameter is never null we still could call AssertIsOnTargetThread after the nullptr check.

Comment 1

[Andi [:andi]]

Attachment: Bug 1334081 - prevent null pointer dereference in StreamReaderFunc.

Review commit: https://reviewboard.mozilla.org/r/107442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107442/

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8830697 [details]
Bug 1334081 - prevent null pointer dereference in StreamReaderFunc.

https://reviewboard.mozilla.org/r/107442/#review108588

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2da10ec6bdd
prevent null pointer dereference in StreamReaderFunc. r=baku

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2da10ec6bdd