1334573 - Assertion failure: slot.toObject().is<PluralRulesObject>(), at js/src/builtin/Intl.cpp:3504

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[Christian Holler (:decoder)]

The following testcase crashes on mozilla-central revision 8dbe89935366 (build with --enable-posix-nspr-emulation --enable-valgrind --enable-gczeal --disable-tests --enable-debug --enable-optimize, run with --fuzzing-safe --ion-offthread-compile=off min.js):

addIntlExtras(Intl);
addIntlExtras(Intl);


Backtrace:

 received signal SIGSEGV, Segmentation fault.
0x0000000000572468 in js::GlobalObject::addPluralRulesConstructor (cx=cx@entry=0x7ffff6946000, intl=...) at js/src/builtin/Intl.cpp:3504
#0  0x0000000000572468 in js::GlobalObject::addPluralRulesConstructor (cx=cx@entry=0x7ffff6946000, intl=...) at js/src/builtin/Intl.cpp:3504
#1  0x000000000057264a in js::AddPluralRulesConstructor (cx=cx@entry=0x7ffff6946000, intl=..., intl@entry=...) at js/src/builtin/Intl.cpp:3523
#2  0x00000000004490eb in AddIntlExtras (cx=0x7ffff6946000, argc=<optimized out>, vp=<optimized out>) at js/src/shell/js.cpp:913
#3  0x000000000053512d in js::CallJSNative (cx=cx@entry=0x7ffff6946000, native=0x449000 <AddIntlExtras(JSContext*, unsigned int, JS::Value*)>, args=...) at js/src/jscntxtinlines.h:239
[...]
#16 main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at js/src/shell/js.cpp:7960


Marking fuzzblocker as this is happening frequently.

Comment 1

[Fuzzing Team]

JSBugMon: Bisection requested, result:
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/a67ac2fe858f
user:        André Bargull
date:        Thu Jan 26 04:56:40 2017 -0800
summary:     Bug 1332604 - Part 1: Change Intl prototypes to plain objects. r=Waldo

This iteration took 254.397 seconds to run.

Comment 2

[André Bargull [:anba]]

Attachment: bug1334573.patch

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8831418 [details] [diff] [review]
bug1334573.patch

Review of attachment 8831418 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58e48aa02dce
Remove assertion that Intl.PluralRules.prototype is an Intl.PluralRules instance. r=Waldo

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/58e48aa02dce