133461 - should be one context menu on the right of top menu bar

Status: RESOLVED EXPIRED

(SeaMonkey :: UI Design, defect)

Description

[Jerry]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; Q312461)
BuildID:    2002

There should be one context menu on the right of top menu bar,
User can use it to show or hide some toolbar.

Reproducible: Always
Steps to Reproduce:
1.move mouse to right of top menu bar
2.right click 
3.

Actual Results:  nothing happend

Expected Results:  should be one context menu to switch some toolbar

IE 6 has such an context menu.

Comment 1

[Jerry]

Attachment: check this pic

Comment 2

[Paul Wyskoczka]

--> Context Menus

Comment 3

[sairuh (rarely reading bugmail)]

->blake

Comment 4

[Jerry]

Attachment: patch for this

Comment 5

[Jerry]

blaker, can you give r?

Comment 6

[timeless]

Comment on attachment 76342 [details] [diff] [review]
patch for this

this r= is conditional on a signoff from the browser ui module owner or a peer.

Comment 7

[Blake Ross]

This patch isn't completely correct.  We should be reusing the View > Toolbars
submenu.

Also, how does it work with toolbar items that have their own context menus
(urlbar, back/fwd buttons, personal toolbar items)?

Comment 8

[Jerry]

The patch is reusing View->Toolbar submenu.

Comment 9

[Jerry]

blaker, I have tested my patch with netscape7 pr1,
it works even there is a personal toolbar.

so what do you think about this patch?

Comment 10

[Jerry]

jag, can you give sr?

Comment 11

[jag (Peter Annema)]

Jerry, what blake is trying to say (I think) is that you are duplicating code
from the View -> Show/Hide menu. It would be nice if you could somehow share the
xul and js from that menu to save on cost of maintainance (you may have noticed
that the View -> Show/Hide menu has "Tab Bar" and "Navigation Bar", which don't
appear on your context menu).

Also, if you look at the navigation bar for example, your context menu would
only show up when you right-click on the reload button, the stop button, the
throbber or on one of the thin sections in between, because the url text input,
the back button and the forward button already have a context menu which will
override yours. It would be nice if these context menu items could would be made
part of those context menus too.

I'm not going to sr this patch without blake's buy-in.

Comment 12

[Jerry]

Attachment: another patch (total reuse view menu)

Comment 13

[Jerry]

Attachment: screenshot for second patch

Comment 14

[Jerry]

this bug is for IE's compatible.
I  add context menu just like IE does.


for Code reusing , first patch reusing  View-> menu's  lable, accesskey, observer.
and second patch reuse View->menu totally.

But I think the first patch is better.
I dont think Tab Bar and Nav Bar are fit here.

Comment 15

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 16

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420