1334650 - Use full series name to describe series in performance panel, not just suite

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

It would be useful for debugging purposes to show the full name of the performance test in the performance panel for treeherder, rather than just the suite. E.g. in https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3433f9ee8e4a7b823d19399ef8444b208819ab4&selectedJob=72660067 we could show `build times summary opt nightly taskcluster-c4.2xlarge` and not just `build times`

If this had been the case I probably would have noticed that the patch for bug 1334534 was incomplete. There have been other cases where showing the full series name would have been useful as well (e.g. bug 1333860).

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1334650 > mozilla:master

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 8831283 [details] [review]
[treeherder] wlach:1334650 > mozilla:master

Good idea, LGTM

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b14eb95c571e00683d5fe9a283ac532623c7f23f
Bug 1334650 - Use full series name in performance panel (#2115)

Comment 4

[William Lachance (:wlach)]

This doesn't look good for test cases where we're showing a subtest (e.g. num constructors):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=252a4e4ae697ce633b84ef96131fad2c433f8a91&selectedJob=74906074

You get a value like `compiler_metrics num_static_constructors opt_num_static_constructors` when what we want is `compiler_metrics num_static_constructors opt`. We can actually fix this by removing some special case code from the performance panel.

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1334650-fixup > mozilla:master

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8834151 [details] [review]
[treeherder] wlach:1334650-fixup > mozilla:master

This is a minor followup to the first patch. Wish I had caught this the first time, oh well... :)

Comment 7

[Robert Wood [:rwood]]

Comment on attachment 8834151 [details] [review]
[treeherder] wlach:1334650-fixup > mozilla:master

lgtm

Comment 8

[William Lachance (:wlach)]

Re-resolving

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8669090200fc7402fe50b7e7c8dad5622fdf2903
Bug 1334650 - Fix display of non-summary tests in job performance panel (#2139)