Closed
Bug 1334879
Opened 7 years ago
Closed 7 years ago
Recover/create reviewer suggestion for Core - JavaScript Engine and related components.
Categories
(bugzilla.mozilla.org :: Administration, task)
Tracking
()
RESOLVED
FIXED
People
(Reporter: arai, Assigned: dkl)
Details
Currently there's no reviewer suggestion for the following components: * Core - JavaScript Engine * Core - JavaScript Engine: JIT * Core - JavaScript: GC * Core - JavaScript: Internationalization API * Core - JavaScript: Standard Library * Core - js-ctypes There was reviewer suggestion for some of them, but at some point the list disappeared. Here are links for module owner/peer for some of them: https://wiki.mozilla.org/Modules/All#JavaScript https://wiki.mozilla.org/Modules/All#JavaScript_JIT https://wiki.mozilla.org/Modules/All#js-ctypes
Assignee | ||
Comment 1•7 years ago
|
||
I also am not sure what happened to them. Which people of module/component each should be the suggested reviewers? Should we just add the module owner and all peers to the suggested reviewers list? dkl
Flags: needinfo?(arai.unmht)
Reporter | ||
Comment 2•7 years ago
|
||
discussed in #jsapi channel. JavaScript Engine : https://wiki.mozilla.org/Modules/All#JavaScript JavaScript Engine: JIT : https://wiki.mozilla.org/Modules/All#JavaScript_JIT JavaScript: GC : https://wiki.mozilla.org/Modules/All#JavaScript JavaScript: Internationalization API : :Waldo JavaScript: Standard Library : https://wiki.mozilla.org/Modules/All#JavaScript js-ctypes : https://wiki.mozilla.org/Modules/All#js-ctypes
Flags: needinfo?(arai.unmht)
Reporter | ||
Comment 3•7 years ago
|
||
is there any other thing I can do for this bug?
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Tooru Fujisawa [:arai] from comment #2) > discussed in #jsapi channel. > > JavaScript Engine : > https://wiki.mozilla.org/Modules/All#JavaScript > JavaScript: GC : > https://wiki.mozilla.org/Modules/All#JavaScript > JavaScript: Standard Library : > https://wiki.mozilla.org/Modules/All#JavaScript I have added the 'JavaScript' module owner as the suggested reviewer for the #JavaScript related components. But not sure whom from the peers list I should add as there a lot of them. Some are not even with the company and the email address is not valid anymore. So which one of the peers should I add to in addition to the module owner? > JavaScript Engine: JIT : > https://wiki.mozilla.org/Modules/All#JavaScript_JIT > JavaScript: Internationalization API : :Waldo > js-ctypes : > https://wiki.mozilla.org/Modules/All#js-ctypes These are done. dkl
Flags: needinfo?(arai.unmht)
Reporter | ||
Comment 5•7 years ago
|
||
Thanks! I luckily found a screenshot of suggestion list, thanks to bugzilla's bug ;) https://bug1213791.bmoattachments.org/attachment.cgi?id=8672556 so, here's the list from the screenshot, excluding inactive peers: luke@mozilla.com jorendorff@mozilla.com jwalden+bmo@mit.edu jdemooij@mozilla.com hv1989@gmail.com kvijayan@mozilla.com dvander@alliedmods.net wmccloskey@mozilla.com nicolas.b.pierron@mozilla.com sstangl@mozilla.com bhackett1024@gmail.com sphink@gmail.com till@tillschneidereit.net evilpies@gmail.com shu@mozilla.com mrbkap@mozilla.com arai.unmht@gmail.com also list from wiki page who reviewed patch in JavaScript Engine recently: n.nethercote@gmail.com nfitzgerald@mozilla.com sunfish@mozilla.com bobbyholley@gmail.com
Flags: needinfo?(arai.unmht)
Assignee | ||
Comment 6•7 years ago
|
||
All done.
Assignee: nobody → dkl
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•