1335316 - Include URL parameters in network request logs

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Sebastian Zartner [:sebo]]

Network requests logged to the Web Console are missing URL parameters.
This requires a user to expand the requests or switch to the Network Monitor, if the same URL path is called with different parameters.

FWIW, in Firebug the URLs included the parameters and were truncated in case they are too long.

Sebastian

Comment 1

[Sebastian Zartner [:sebo]]

This feature may be optional (i.e. behind a preference) in case there are concerns that long URLs may cause UI issues.

Additional note about Firebug's implementation: It showed the full URL on hover.

Sebastian

Comment 2

[Sebastian Zartner [:sebo]]

Btw. this was asked for at http://stackoverflow.com/q/41945654/432681.

Sebastian

Comment 3

[Tim Nguyen :ntim]

Instead of adding a preference for these things, I'd prefer if they were implemented naturally. A good solution would be doing better cropping (i.e. at the center), so we can have both the end, and the start of the URL. Or maybe a start cropping would be better.

Comment 4

[Tim Nguyen :ntim]

Also, the new console gets rid of the long status code at the end which definitively helps.

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to Tim Nguyen :ntim from comment #3)
> Instead of adding a preference for these things, I'd prefer if they were
> implemented naturally. A good solution would be doing better cropping (i.e.
> at the center), so we can have both the end, and the start of the URL. Or
> maybe a start cropping would be better.

Side note: Cropping in the middle of a string via CSS is not possible yet. See bug 740910.

Sebastian

Comment 6

[Sebastian Zartner [:sebo]]

I assume this shouldn't be too hard to implement, so I add the 'good-first-bug' keyword.

Sebastian

Comment 7

[Robert Masen]

Currently the query params are removed here
> request.url.replace(/\?.+/, "")
By simply removing the replace statement, the query params would be viewable, however long urls will be trimmed by the standard styling. Currently the expanded view of the line contains a params tab with any included params. While it is possible to have the beginning of the request truncated, this does not guarantee that all query params would be viewable.

Comment 8

[Robert Masen]

Attachment: Bug 1335316

Review commit: https://reviewboard.mozilla.org/r/177852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177852/

Comment 9

[Robert Masen]

Attachment: not sure how that line got deleted... Bug 1335316

Review commit: https://reviewboard.mozilla.org/r/177860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177860/

Comment 10

[Robert Masen]

Comment on attachment 8906107 [details]
Bug 1335316

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177852/diff/1-2/

Comment 11

[Abhinav Koppula]

Hi Sebastian,
Is this issue still open for anyone to take?

Comment 12

[Sebastian Zartner [:sebo]]

I redirect that question to Robert, as he already started working on it (without being assigned).

Sebastian

Comment 13

[Robert Masen]

Abhinav,
  Feel free to work on this issue. I submitted my pull request 4 months ago and it hasen't been reviewed. I am not sure I understand how this whole process is supposed to work but I am not sure when I will have time again to figure it out.

Comment 14

[Sebastian Zartner [:sebo]]

Thank you for your answer, Robert! The normal process is to ask someone specific for review.
I think in this case it might be Honza, so I've set him as reviewer and mentor for this bug.
@Honza Please redirect the review if you can't review this patch.

Sebastian

Comment 15

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I like the idea of having URL params displayed by default.

Harald, what do you think?

Honza

Comment 16

[:Harald Kirschner :digitarald]

I like it as it is one of the essential information that makes up a request (URL, method & params)

Comment 17

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8906107 [details]
Bug 1335316

https://reviewboard.mozilla.org/r/177852/#review215706

Please rebase on the latest HEAD (the file has been renamed)

Thanks!
Honza

Comment 18

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8906111 [details]
not sure how that line got deleted... Bug 1335316

https://reviewboard.mozilla.org/r/177860/#review215708

Please merge this patch into the first one.
Honza

Comment 19

[Sebastian Zartner [:sebo]]

Abhinav, are you still interested in finishing up the patch for this?

Sebastian

Comment 20

[Abhinav Koppula]

Attachment: Bug 1335316 - Include URL parameters in network request logs;

Review commit: https://reviewboard.mozilla.org/r/214356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214356/

Comment 21

[Abhinav Koppula]

Hi Sebastian,
Sorry for the delay. Have rebased the patch.

Comment 22

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8944033 [details]
Bug 1335316 - Include URL parameters in network request logs;

https://reviewboard.mozilla.org/r/214356/#review220154

Thanks!

R+ assuming try is green

Honza

Comment 23

[Abhinav Koppula]

Try is green - https://treeherder.mozilla.org/#/jobs?repo=try&revision=a75caab13739

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d74298d2f241
Include URL parameters in network request logs; r=Honza

Comment 25

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d74298d2f241

Comment 26

[Mohammed Adam]

I Have tried to Reproduce the Same Bug in Firefox Nightly  60.0a1 on Windows 10 (64bit) & Windows 7 (32bit)

------------------------------------------------------------------------------------------
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180212100154
Firefox Version: 60.0a1
------------------------------------------------------------------------------------------
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180211220056
Firefox Version: 60.0a1
------------------------------------------------------------------------------------------

But the Bug has been Fixed. 

[Steps to Reproduce]

1) Started the Firefox with Cleaned Profile
2) Then opened this URL https://bugzilla.mozilla.org/show_bug.cgi?id=1335316 in a New tab or Try any other URLs too.
3) Press the Ctrl+Shift+E for Network Monitor 
4) To Perform a request or "Reload" the same page to see detailed information about network activity.

Actual Results:
URL parameters Displayed in the requests logged to the console.

Status: Fixed & Verified 

[bugday-20180214]