Closed
Bug 1335335
Opened 7 years ago
Closed 7 years ago
Tab move between different windows does not work when e10s is enabled.
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files, 12 obsolete files)
4.75 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
34.76 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
Tab move between different windows does not work yet.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8831973 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•7 years ago
|
Attachment #8831973 -
Attachment is obsolete: true
Attachment #8831973 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
The followings needs to be addressed. - WebRenderCommands are not kept in WebRenderBridgeParent. Client side needs to resend all commands in this case. - ImageKey is local to each window. Each window has different webrender instance.
Assignee | ||
Updated•7 years ago
|
Summary: Tab move between different windows does not work → Tab move between different windows does not work when e10s is enabled.
Updated•7 years ago
|
Whiteboard: [gfx-noted]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Updated•7 years ago
|
Attachment #8831975 -
Attachment is obsolete: true
Assignee | ||
Comment 6•7 years ago
|
||
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8877033 -
Attachment is obsolete: true
Assignee | ||
Comment 8•7 years ago
|
||
Attachment #8878403 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8879500 -
Attachment description: Tab move between different windows when e10s is enabled → patch - Tab move between different windows when e10s is enabled
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6db606e3c0ef8c10f24a689901039a1a8d8493ce
Assignee | ||
Comment 10•7 years ago
|
||
Fixed crash during tab move.
Attachment #8879500 -
Attachment is obsolete: true
Assignee | ||
Comment 11•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5bb4a4d71633931dbb8faadf791f6ce70bb847a
Assignee | ||
Comment 12•7 years ago
|
||
Attachment #8879864 -
Attachment is obsolete: true
Assignee | ||
Comment 13•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e39c1eb9b6581734edb78d053787d02f16a52ddf
Assignee | ||
Comment 14•7 years ago
|
||
Attachment #8880216 -
Attachment is obsolete: true
Assignee | ||
Comment 15•7 years ago
|
||
Attachment #8880259 -
Attachment is obsolete: true
Assignee | ||
Comment 16•7 years ago
|
||
attachment 8880321 [details] [diff] [review] still has one problem. On windows, sometimes moved tabs were not re-rendered. It was cased by un-handled obsoleted DPEnd message. Obsoleted HandleDPEnd() was called after UpdateWebRender(). The obsoleted message was just dropped. Then client side just waited a transaction complete of the obsoleted message.
Assignee | ||
Comment 17•7 years ago
|
||
Attachment #8880321 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8880724 -
Attachment description: patch - Tab move between different windows when e10s is enabled → patch part 1 - Tab move between different windows when e10s is enabled
Assignee | ||
Comment 18•7 years ago
|
||
Update a comment.
Attachment #8880724 -
Attachment is obsolete: true
Assignee | ||
Comment 19•7 years ago
|
||
Assignee | ||
Comment 20•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ff92cd4d19679bf50b11ebdc41128c8d7604e66
Assignee | ||
Updated•7 years ago
|
Attachment #8880726 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•7 years ago
|
Attachment #8880733 -
Flags: review?(nical.bugzilla)
Comment 21•7 years ago
|
||
Comment on attachment 8880726 [details] [diff] [review] patch part 1 - Tab move between different windows when e10s is enabled Review of attachment 8880726 [details] [diff] [review]: ----------------------------------------------------------------- Please write a big comment explaining why it is hard to avoid tracking old and new ids. I am hopeful that some time in the future we can refactor the layers code so that we don't have to go through this complication.
Attachment #8880726 -
Flags: review?(nical.bugzilla) → review+
Updated•7 years ago
|
Attachment #8880733 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 22•7 years ago
|
||
Apply the comment.
Attachment #8880726 -
Attachment is obsolete: true
Attachment #8882286 -
Flags: review+
Comment 23•7 years ago
|
||
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ac18f9244933 Tab move between different windows does not work when e10s is enabled r=nical https://hg.mozilla.org/integration/mozilla-inbound/rev/c5dbfdc1892e Manually call DidComposite() when transaction was dropped because of obsoleted command r=nical
Comment 24•7 years ago
|
||
Backed out for build bustage: version control conflict in maker file at WebRenderBridgeParent.h:235: https://hg.mozilla.org/integration/mozilla-inbound/rev/26fa5c01d1a13ffb8999a3ac318737d272f05e6d https://hg.mozilla.org/integration/mozilla-inbound/rev/1351044edbaa5a08208af54447e38a885321566d Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c5dbfdc1892e6003fb128ea305bcf2eb01158c27&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=110829813&repo=mozilla-inbound /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/layers/WebRenderBridgeParent.h:235:1: error: version control conflict marker in file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/layers/WebRenderBridgeParent.h:235:1: error: version control conflict marker in file /home/worker/workspace/build/src/gfx/layers/wr/WebRenderBridgeParent.cpp:393:24: error: out-of-line definition of 'HandleDPEnd' does not match any declaration in 'mozilla::layers::WebRenderBridgeParent' /home/worker/workspace/build/src/gfx/layers/wr/WebRenderBridgeParent.cpp:521:54: error: too many arguments to function call, expected 9, have 10 /home/worker/workspace/build/src/gfx/layers/wr/WebRenderBridgeParent.cpp:541:54: error: too many arguments to function call, expected 9, have 10
Flags: needinfo?(sotaro.ikeda.g)
Assignee | ||
Comment 25•7 years ago
|
||
Rebased.
Attachment #8882286 -
Attachment is obsolete: true
Flags: needinfo?(sotaro.ikeda.g)
Attachment #8882434 -
Flags: review+
Assignee | ||
Comment 26•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4291f23baf7542d915727cfebfb425d743db8fdc
Comment 27•7 years ago
|
||
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3bc8240fce38 Tab move between different windows does not work when e10s is enabled r=nical https://hg.mozilla.org/integration/mozilla-inbound/rev/b60b291fce96 Manually call DidComposite() when transaction was dropped because of obsoleted command r=nical
Comment 28•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3bc8240fce38 https://hg.mozilla.org/mozilla-central/rev/b60b291fce96
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•