1335514 - Register device with FxA before obtaining a signed certificate

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Firefox Accounts, defect, P5)

Description

[:Grisha Kruglov]

Side-effect of calling /certificate/sign is creation of a placeholder fxa device record if one isn't already present. From rfkelly ([0]):

> * If we get a request to /certificate/sign, and
> * That sessionToken does not have a device id associated with it, and
> * There's no ?service= query parameter, or there's service=sync, then
> * Create a device record for that sessionToken, because it's pretty definitely a 
> device using sync

We should attempt to perform FxA device registration before calling /certificate/sign, if possible. That call happens as part of the "Cohabiting" state action, right before we move into "Married" state ("good to sync!"). Device registration currently happens once we're in the "Married" state. See [1] and [2].

[0] https://bugzilla.mozilla.org/show_bug.cgi?id=1332858#c7
[1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/login/Cohabiting.java?q=path%3ACohabiting.java&redirect_type=single#27
[2] https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/sync/FxAccountSyncAdapter.java#541

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Bulk edit: moving potentially relevant issues from disabled Android Background Services product to Firefox for Android.

Removing priority to throw back to triage owners: please close these bugs if they're no longer relevant! Thanks!

Comment 2

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.