Closed
Bug 1335515
Opened 7 years ago
Closed 7 years ago
MediaEngine.h fails to compile with --disable-webrtc
Categories
(Core :: WebRTC, defect, P1)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
|
2.24 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
libdom_bindings.a.desc
In file included from dom/media/Unified_cpp_dom_media1.cpp:137:
In file included from dom/media/MediaDeviceInfo.cpp:7:
In file included from dist/include/mozilla/MediaManager.h:8:
dist/include/MediaEngine.h:229:28: error: reference to 'ipc' is ambiguous
const ipc::PrincipalInfo& aPrincipalInfo,
^
ipc/ipdl/_ipdlheaders/mozilla/ipc/PBackgroundSharedTypes.h:577:11: note: candidate found by name lookup is 'mozilla::ipc'
namespace ipc {
^
dist/include/mozilla/dom/ipc/StructuredCloneData.h:33:11: note: candidate found by name lookup is 'mozilla::dom::ipc'
namespace ipc {
^
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → mats
Attachment #8832179 -
Flags: review?(cpearce)
|
||
Updated•7 years ago
|
Rank: 15
Priority: -- → P1
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8832179 [details] [diff] [review] fix Review of attachment 8832179 [details] [diff] [review]: ----------------------------------------------------------------- This is WebRTC code, not playback, so passing review to Jesup.
Attachment #8832179 -
Flags: review?(cpearce) → review?(rjesup)
|
||
Updated•7 years ago
|
Attachment #8832179 -
Flags: review?(rjesup) → review+
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/00aaf25b6e05 Add mozilla:: prefix to make MediaEngine.h compile with --disable-webrtc. r=jesup
|
|
||
Comment 4•7 years ago
|
||
Part of this already landed in Bug 1335250; I landed the remaining line.
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00aaf25b6e05
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•