Closed
Bug 1335997
Opened 7 years ago
Closed 7 years ago
Don't use virtual method for non override methods in EditorBase and TextEditor
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(2 files)
Although some methods don't override by another class, we use virtual keyword. So we shouldn't use virtual method for EditorBase and TextEditor if possible.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → m_kato
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832768 [details] Bug 1335997 - Part 1. Don't use virtual method for GetAndInitDocEncoder and InsertTextFromTransferable. https://reviewboard.mozilla.org/r/109006/#review110188
Attachment #8832768 -
Flags: review?(masayuki) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832769 [details] Bug 1335997 - Part 2. Don't use virtual method for NotifyDocumentListeners and ScrollSelectionIntoView. https://reviewboard.mozilla.org/r/109008/#review110190
Attachment #8832769 -
Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/abb609307363 Part 1. Don't use virtual method for GetAndInitDocEncoder and InsertTextFromTransferable. r=masayuki https://hg.mozilla.org/integration/autoland/rev/d6fd02e91afb Part 2. Don't use virtual method for NotifyDocumentListeners and ScrollSelectionIntoView. r=masayuki
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/abb609307363 https://hg.mozilla.org/mozilla-central/rev/d6fd02e91afb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•