Closed
Bug 1336249
Opened 7 years ago
Closed 7 years ago
Improve and Add More UI Testing
Categories
(Conduit :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davidwalsh, Assigned: davidwalsh)
Details
Attachments
(3 files)
At present we have a few very basic tests but we should improve that. We should add some route testing and various other tests for other components.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8833464 [details] autoland-ui: Improve tests for ActionButtons by ensuring the land button functions properly. (Bug 1336249) https://reviewboard.mozilla.org/r/109714/#review110762 :thumbsup:
Attachment #8833464 -
Flags: review?(imadueme) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8833465 [details] autoland-ui: Create Route tests as well as ensure babel works properly within jest (Bug 1336249). https://reviewboard.mozilla.org/r/109716/#review110764 ::: autoland/ui/src/components/AutolandController.jsx:14 (Diff revision 2) > + > + defaultState = { data: null, error: null }; > + > constructor(props) { > super(props); > - this.state = this.getInitialState(); > + this.state = this.defaultState; Any reason for not putting this as a field at the top like in your gist?
Attachment #8833465 -
Flags: review?(imadueme) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8833466 [details] autoland-ui: Create AutolandController tests (Bug 1336249). https://reviewboard.mozilla.org/r/109718/#review110766 ::: autoland/ui/src/components/AutolandController.jsx:85 (Diff revision 2) > } > > // This is the default text for the element while we fetch data > // during the initial widget creation > if (data === null) { > - return <span>Fetching data...</span>; > + return <span className="fetching-data">Fetching data...</span>; Hopefully our css names don't start conflicting...
Attachment #8833466 -
Flags: review?(imadueme) → review+
Assignee | ||
Comment 9•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8833465 [details] autoland-ui: Create Route tests as well as ensure babel works properly within jest (Bug 1336249). https://reviewboard.mozilla.org/r/109716/#review110764 > Any reason for not putting this as a field at the top like in your gist? While it's cute to do this, using `this` outside of a method seems dirty. :/
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8833464 [details] autoland-ui: Improve tests for ActionButtons by ensuring the land button functions properly. (Bug 1336249) https://reviewboard.mozilla.org/r/109714/#review111636
Attachment #8833464 -
Flags: review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8833465 [details] autoland-ui: Create Route tests as well as ensure babel works properly within jest (Bug 1336249). https://reviewboard.mozilla.org/r/109716/#review111644
Attachment #8833465 -
Flags: review+
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8833466 [details] autoland-ui: Create AutolandController tests (Bug 1336249). https://reviewboard.mozilla.org/r/109718/#review111646
Attachment #8833466 -
Flags: review+
Comment 13•7 years ago
|
||
Pushed by smacleod@mozilla.com: https://hg.mozilla.org/automation/conduit/rev/cf4595460e76 autoland-ui: Improve tests for ActionButtons by ensuring the land button functions properly. r=imadueme,smacleod https://hg.mozilla.org/automation/conduit/rev/399a155c565d autoland-ui: Create Route tests as well as ensure babel works properly within jest . r=imadueme,smacleod https://hg.mozilla.org/automation/conduit/rev/8ec8bab82a62 autoland-ui: Create AutolandController tests . r=imadueme,smacleod
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Assignee: nobody → dwalsh
You need to log in
before you can comment on or make changes to this bug.
Description
•