Closed
Bug 1336869
Opened 7 years ago
Closed 7 years ago
Modify the access key for "unmute tab" option
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
VERIFIED
FIXED
Firefox 54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | verified |
People
(Reporter: alwu, Assigned: alwu)
Details
(Whiteboard: [testday-20170428])
Attachments
(1 file)
Fork from bug1336309 comment2, unmuteTab used "M" as access key, but "M" is not the first character of "unmute". We should change to "U" or "m".
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8833837 [details] Bug 1336869 - modify the access key for 'unmute tab'. https://reviewboard.mozilla.org/r/109960/#review111130
Attachment #8833837 -
Flags: review?(jaws) → review+
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ccbbb9aabf6 modify the access key for 'unmute tab'. r=jaws
|
||
Comment 4•7 years ago
|
||
Funny story, we have a test which makes sure you didn't change that (or, really, that you didn't change that without telling it about the change). Backed out in https://hg.mozilla.org/integration/autoland/rev/28f5dd107842 for https://treeherder.mozilla.org/logviewer.html#?job_id=74999878&repo=autoland
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 6•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=28987f3694b079c03de703e0abb291200263f589
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a31cace18fc6 modify the access key for 'unmute tab'. r=jaws
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a31cace18fc6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
|
||
Comment 10•7 years ago
|
||
Bug Verified [bugday-20170302]
|
||
Comment 11•7 years ago
|
||
Verified in Firefox 54 beta 3 testday (https://public.etherpad-mozilla.org/p/testday-20170428).
You need to log in
before you can comment on or make changes to this bug.
Description
•