1336944 - Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays.

Status: RESOLVED FIXED

(Toolkit :: Storage, defect, P1)

Description

[Marco Bonardo [:mak]]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

Currently binding an Array tries to bind it as a Blob.
This clashes with bug 483318, that would like to bind Arrays for IN clauses.

We should change Sqlite.jsm to bind only typedArrays as blobs.

We should fix this before FF53 ships, to avoid creating previous usage of Array to bind blobs.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1336944 - Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays.

Currently an Array is bound as a blob. Unfortunately this occupies the best javascript
code path to bind an array to an IN clause in the future.
We would like Arrays to bind to IN lists, while still keeping a nice interface to bind blobs.
This patch makes Uint8Array bind to blob, while Array is left available for future use.

Review commit: https://reviewboard.mozilla.org/r/110154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110154/

Comment 2

[Marcia Knous [:marcia]]

Tracking 53/54+ so we have alignment befor 53 ships.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8834072 [details]
Bug 1336944 - Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays.

https://reviewboard.mozilla.org/r/110154/#review111496

So there are no non-test consumers right now? Interesting...

Comment 4

[:Gijs (he/him)]

Comment on attachment 8834072 [details]
Bug 1336944 - Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays.

https://reviewboard.mozilla.org/r/110154/#review111500

::: toolkit/modules/tests/xpcshell/test_sqlite.js:1106
(Diff revision 1)
>    const bindings = [
>      {
>        null_col: null,
>        integer_col: 12345,
>        text_col: "qwerty",
> -      blob_col: new Array(256).fill(undefined).map( (value, index) => index % 256 ),
> +      blob_col: new Uint8Array(256).fill(undefined).map( (value, index) => index % 256 ),

Does this work, and/or is filling it with undefined here useful, given the map() call? If it is, shouldn't we fill with 0?

Comment 5

[Marco Bonardo [:mak]]

(In reply to :Gijs from comment #4)
> Does this work, and/or is filling it with undefined here useful, given the
> map() call? If it is, shouldn't we fill with 0?

Yeah, it's the same, afaict:
new Uint8Array(10).fill(undefined)
> Uint8Array [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ]

I will just change undefined with 0, for clarity.

Comment 6

[Marco Bonardo [:mak]]

oh but yeah, the fill itself is pointless, will just remove it.

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8834072 [details]
Bug 1336944 - Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/110154/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf0424523e69
Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays. r=Gijs

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cf0424523e69

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 8834072 [details]
Bug 1336944 - Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1247602 
[User impact if declined]: We'd be shipping an API that is changing the next version
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just changing Array to Uint8Array, new API
[String changes made/needed]: none

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8834072 [details]
Bug 1336944 - Change Sqlite.jsm to bind TypedArrays as Blobs, not common Arrays.

Ship new API. Aurora53+.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eae7e45deb55