1337026 - Firefox Menu not using Sync account image but Preferences shows specific account image

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: sync-missing-account-image-menupanel.png

See attached image.

I have an account image associated with my account, and this shows in about:preferences, but on the Firefox menu it shows the generic image.

Seen on 54.0a1 (2017-02-06) (64-bit) on Windows 10 Nightly.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Edouard or Mark, could this be fallout from bug 1335538?

Comment 2

[Edouard Oger [:eoger]]

Same problem here, it's probably because of this patch. I'm on this.

Comment 3

[Edouard Oger [:eoger]]

Attachment: Bug 1337026 - Cache the FxA profile in the UI.

Review commit: https://reviewboard.mozilla.org/r/110142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110142/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

https://reviewboard.mozilla.org/r/110142/#review111154

::: browser/base/content/browser-fxaccounts.js:160
(Diff revision 1)
>      this.updateUI();
>    },
>  
>    // Note that updateUI() returns a Promise that's only used by tests.
>    updateUI() {
> +    debugger

this should be removed. it will probably fail eslint also.

Comment 5

[Edouard Oger [:eoger]]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/110142/diff/1-2/

Comment 6

[Edouard Oger [:eoger]]

Yup sorry it was not meant for review yet, just switching computers :)

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

https://reviewboard.mozilla.org/r/110142/#review111312

Thanks Edouard - once this lands, please request uplift of this and bug 1335538

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fad13bbe02de
Cache the FxA profile in the UI. r=markh

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fad13bbe02de

Comment 10

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: We should work hard to get this into 52
User impact if declined: Increased volume to profile.accounts.firefix.com
Fix Landed on Version: 54
Risk to taking this patch (and alternatives if risky): Fairly low risk, limited to the Sync UI, and even then, limited to the user's profile image not being shown.
String or UUID changes made by this patch:  None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Approval Request Comment
[Feature/Bug causing the regression]: 51
[User impact if declined]: As above
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes, as described in the bug.
[List of other uplifts needed for the feature/fix]: Bug 1335538
[Is the change risky?]: Low
[Why is the change risky/not risky?]: Fairly low risk, limited to the Sync UI, and even then, limited to the user's profile image not being shown.
[String changes made/needed]: None

Comment 11

[Gerry Chang [:gchang]]

Hi Brindusa, 
Could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!

Comment 12

[Gerry Chang [:gchang]]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

For ESR, it doesn't match the esr criteria (only sec-high & sec-critical issues). ESR45-.

Comment 13

[Brindusa Tot, Desktop QA]

Roxana, could you please verify this bug.

Comment 14

[Mark Hammond [:markh] [:mhammond]]

Note Kanchan has been doing QA for this in bug 1335538 - this is a followup of that.

Comment 15

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

oops - see comment 10 - I accidentally requested esr45 instead of esr52.

Comment 16

[roxleitan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170214030231

I tested this issue on Windows 10 x64, Ubuntu 16.04 and Mac OS X 10.11 on Nightly 54.0a1 (2017-02-06)(Build ID:20170206030211) and latest Nightly 54.0a1 (2017-02-14) and could not reproduce it.

Can you please check with your account if the issue is still reproducible on the latest Nightly?

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

I can confirm that this is now fixed in the latest Nightly.

Comment 18

[Gerry Chang [:gchang]]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

Fix a sync UI issue and was verified in nightly. Aurora53+.

Comment 19

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

This isn't esr-specific, and until the 52 release changes in beta are synced to esr52.

Comment 20

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

FxA UI fix, follow-up for 1335538, beta52+

Comment 21

[Carsten Book [:Tomcat]]

aurora needs rebase:

grafting 396859:fad13bbe02de "Bug 1337026 - Cache the FxA profile in the UI. r=markh"
merging browser/base/content/browser-fxaccounts.js
merging browser/base/content/test/general/browser_fxaccounts.js
warning: conflicts while merging browser/base/content/browser-fxaccounts.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/base/content/test/general/browser_fxaccounts.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 22

[Edouard Oger [:eoger]]

Attachment: bug-1337026-aurora.patch

Rebased for Aurora, thanks.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c589ef7d5db5

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce5e991a8c21

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/ce5e991a8c21

Comment 26

[Kanchan Kumari QA]

QA Verification: This is to confirm that this issue is fixed on Aurora 53, Beta 52 and ESR 52.

Comment 27

[Kanchan Kumari QA]

This bug is reproducible in the today's nightly. I performed mozregression and it looks like the following bug has the  changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1346987

Comment 28

[Kanchan Kumari QA]

I don't see account image either in about:preferences or in Firefox menu.

Account image only appears under https://accounts.firefox.com/settings?

Comment 29

[Kanchan Kumari QA]

Not reproducible in today's nightly.