Closed
Bug 1337230
Opened 7 years ago
Closed 7 years ago
HTTP2 Huffman tables should go in a read-only data section
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
3.10 KB,
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
Please see bug 1334254 comment 0 for background. This patch moves about 10k from writable .data to read-only .rdata. I originally had a version of this patch that adds constexpr to all of the Huffman structures, but lately I've been having too much trouble with constexpr and internal compiler errors. I have to resort to removing the inner 'const', even though it's a bit ugly. (Though, HuffmanOutgoing wasn't const at either level, so that one's easy!)
Attachment #8834234 -
Flags: review?(hurley)
Attachment #8834234 -
Flags: review?(hurley) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f1160dc58eb8 Tweak the const-ness on the HTTP2 Huffman tables. r=hurley
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f1160dc58eb8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•