Closed
Bug 1337238
Opened 7 years ago
Closed 7 years ago
Custom Tabs: progress bar on the custom bar for loading page
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox55 verified)
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: ryang, Assigned: walkingice)
References
Details
Attachments
(3 files)
progress bar is needed on the custom bar for displaying the loading page.
Updated•7 years ago
|
Summary: Cutom Tabs: progress bar on the custom bar for loading page → Custom Tabs: progress bar on the custom bar for loading page
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Assignee: nobody → walkingice0204
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8848966 [details] Bug 1337238 - Reuse some id resources in layout xml file https://reviewboard.mozilla.org/r/121810/#review123844 Why is it toolbar->actionbar, but progress -> toolbar_progress? Should be both 'toolbar' (or 'actionbar')? :)
Attachment #8848966 -
Flags: review?(s.kaspari) → review+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8848967 [details] Bug 1337238 - Involve ProgressBar to CustomTabsActivity for page loading https://reviewboard.mozilla.org/r/121812/#review123848 Yeah \o/ This was super annoying without a progress bar. :)
Attachment #8848967 -
Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d05c2e4eef15 Reuse some id resources in layout xml file r=sebastian https://hg.mozilla.org/integration/autoland/rev/d6b50ff5c020 Involve ProgressBar to CustomTabsActivity for page loading r=sebastian
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d05c2e4eef15 https://hg.mozilla.org/mozilla-central/rev/d6b50ff5c020
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 9•7 years ago
|
||
Verified as fixed in build 55.0a1 (2017-04-02). Device: Huawei Honor (Android 5.1.1). Progress bar is displayed when a page is loading.
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•