1337303 - Fix the wrong comment in nsHttpChunkedDecoder

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Kershaw Chang [:kershaw]]

The chunked transfer coding [1] is actually coming from RFC2616 [2], not RFC2617.

[1] http://searchfox.org/mozilla-central/rev/f5077ad52f8b90183e73038869f6140f0afbf427/netwerk/protocol/http/nsHttpChunkedDecoder.cpp#30
[2] https://tools.ietf.org/html/rfc2616#section-3.6.1

Comment 1

[Nick Fox [:njfox]]

Submitted changeset for review.

Comment 2

[Nick Fox [:njfox]]

Attachment: Bug 1337303 - Corrected RFC number cited in comments

Reviewed by mcmanus; I had attached this to the wrong bug before.

Comment 3

[Nick Fox [:njfox]]

Attachment: Bug 1337303 - Corrected RFC number cited in comments

Review commit: https://reviewboard.mozilla.org/r/116358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116358/

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 8842509 [details] [diff] [review]
Bug 1337303 - Corrected RFC number cited in comments

Review of attachment 8842509 [details] [diff] [review]:
-----------------------------------------------------------------

somehow you have created a file called commit-message-f58fb you don't want a new file in the repo like that.

Comment 5

[Patrick McManus [:mcmanus]]

Comment on attachment 8842574 [details]
Bug 1337303 - Corrected RFC number cited in comments

https://reviewboard.mozilla.org/r/116358/#review118004

duplicate review request

Comment 6

[Nick Fox [:njfox]]

Attachment: Started over on this commit to fix various issues with the patch

Comment 7

[Nick Fox [:njfox]]

Latest attachment should be good to go. This is a comment-only change, so this patch should not need a try run to prove it's ok. Thanks for your patience while I learned the workflow for contributing.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/74b41dce2486
Corrected RFC number cited in comments. r=mcmanus

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/74b41dce2486

Comment 10

[Patrick McManus [:mcmanus]]

nick, thanks for the patch and this all worked out ok so we don't need to take any action.

But in comment 4 I revoked your r+ and changed it to a r-.. that meant you didn't have a r+ to self-assign and then mark checkin-needed when you fixed the patch. (you fixed it correctly, so I would have then given you the r+.. but I changed it to r- because I wanted to confirm it as you're a new contributor.. I should have made that more clear to you when I did it - its certainly not common.) I'm sure it was just done out of confusion (afterall I shouldn't have r+'d the patch at all if I was unhappy - I just realized afterwards what I was seeing in there with the extra file).

no worries - just clarifying the workflow because the tools (intentionally) let people override this stuff.

Comment 11

[Nick Fox [:njfox]]

Thanks Patrick, and sorry about that. It is definitely out of confusion :) I am reaching out to people on IRC to figure out what I'm doing wrong.