1337496 - Don't animate the pinboard count unless the count actually changed

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder: Frontend, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd argue that the pulse animation should only happen if the count of pinned jobs in the pinboard actually changes.

Thoughts?

Comment 1

[Jonathan French (:jfrench)]

For historical reference my pulsing at all times was intentional, to cue the user when they are trying to pin a job that is already pinned. Versus hitting spacebar on a selected job and thinking "nothing happened" - since there is no UI feedback of any kind in that use case. But whatever you guys want :)

I suppose you could replace the counter pulse on a zero-pin-count change with a blue info notification banner indicating the job is already pinned. But I thought a simple pulse of the counter was less annoying.

Comment 2

[Cameron Dawson [:camd]]

I agree with jfrench on this one. Let's keep it as-is. I think this is a nice way to draw the user's attention to what's happening.