Closed
Bug 1337718
Opened 7 years ago
Closed 7 years ago
Make some methods in editor take Widget*Event instead of nsIDOM*Event as their arguments
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(10 files)
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79a0011de9a3
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8835384 [details] Bug 1337718 part.1 Make EditorBase::HandleKeyPressEvent() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* https://reviewboard.mozilla.org/r/111078/#review112706
Attachment #8835384 -
Flags: review?(m_kato) → review+
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8835385 [details] Bug 1337718 part.2 Make EditorEventListener::ShouldHandleNativeKeyBindings() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* https://reviewboard.mozilla.org/r/111080/#review112718
Attachment #8835385 -
Flags: review?(m_kato) → review+
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8835386 [details] Bug 1337718 part.3 Make EditorEventListener::KeyPress() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* https://reviewboard.mozilla.org/r/111082/#review112720
Attachment #8835386 -
Flags: review?(m_kato) → review+
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8835387 [details] Bug 1337718 part.4 Make EditorEventListener::KeyUp() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* https://reviewboard.mozilla.org/r/111084/#review112722
Attachment #8835387 -
Flags: review?(m_kato) → review+
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8835388 [details] Bug 1337718 part.5 Make IsCtrlShiftPressed() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* https://reviewboard.mozilla.org/r/111086/#review112724
Attachment #8835388 -
Flags: review?(m_kato) → review+
Comment 17•7 years ago
|
||
mozreview-review |
Comment on attachment 8835389 [details] Bug 1337718 part.6 Make EditorEventListener::KeyDown() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* https://reviewboard.mozilla.org/r/111088/#review112736
Attachment #8835389 -
Flags: review?(m_kato) → review+
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8835390 [details] Bug 1337718 part.7 Make IMEStateManager::OnMouseButtonEventInEditor() take WidgetMouseEvent* instead of nsIDOMMouseEvent https://reviewboard.mozilla.org/r/111090/#review112738
Attachment #8835390 -
Flags: review?(m_kato) → review+
Comment 19•7 years ago
|
||
mozreview-review |
Comment on attachment 8835391 [details] Bug 1337718 part.8 Make EditorEventListener::NotifyIMEOfMouseButtonEvent() take WidgetMouseEvent* instead of nsIDOMMouseEvent* https://reviewboard.mozilla.org/r/111092/#review112740
Attachment #8835391 -
Flags: review?(m_kato) → review+
Comment 20•7 years ago
|
||
mozreview-review |
Comment on attachment 8835392 [details] Bug 1337718 part.9 Make IMEStateManager::OnClickInEditor() take const WidgetMouseEvent* instead of nsIDOMMouseEvent* https://reviewboard.mozilla.org/r/111094/#review112742
Attachment #8835392 -
Flags: review?(m_kato) → review+
Comment 21•7 years ago
|
||
mozreview-review |
Comment on attachment 8835393 [details] Bug 1337718 part.10 Make EditorEventListener::MouseClick() and EditorEventListener::HandleMiddleClickPaste() use WidgetMouseEvent as far as possible https://reviewboard.mozilla.org/r/111096/#review112744
Attachment #8835393 -
Flags: review?(m_kato) → review+
Comment 22•7 years ago
|
||
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/2888f135c737 part.1 Make EditorBase::HandleKeyPressEvent() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato https://hg.mozilla.org/integration/autoland/rev/a07723fd11f1 part.2 Make EditorEventListener::ShouldHandleNativeKeyBindings() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato https://hg.mozilla.org/integration/autoland/rev/331fad29a7c4 part.3 Make EditorEventListener::KeyPress() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato https://hg.mozilla.org/integration/autoland/rev/51f5c75cfb6e part.4 Make EditorEventListener::KeyUp() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato https://hg.mozilla.org/integration/autoland/rev/f49e57b87a0b part.5 Make IsCtrlShiftPressed() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato https://hg.mozilla.org/integration/autoland/rev/b12925eebad7 part.6 Make EditorEventListener::KeyDown() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato https://hg.mozilla.org/integration/autoland/rev/b8fb46941569 part.7 Make IMEStateManager::OnMouseButtonEventInEditor() take WidgetMouseEvent* instead of nsIDOMMouseEvent r=m_kato https://hg.mozilla.org/integration/autoland/rev/e1f009677c72 part.8 Make EditorEventListener::NotifyIMEOfMouseButtonEvent() take WidgetMouseEvent* instead of nsIDOMMouseEvent* r=m_kato https://hg.mozilla.org/integration/autoland/rev/942fedc10653 part.9 Make IMEStateManager::OnClickInEditor() take const WidgetMouseEvent* instead of nsIDOMMouseEvent* r=m_kato https://hg.mozilla.org/integration/autoland/rev/3f4ac53f2225 part.10 Make EditorEventListener::MouseClick() and EditorEventListener::HandleMiddleClickPaste() use WidgetMouseEvent as far as possible r=m_kato
Comment 23•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2888f135c737 https://hg.mozilla.org/mozilla-central/rev/a07723fd11f1 https://hg.mozilla.org/mozilla-central/rev/331fad29a7c4 https://hg.mozilla.org/mozilla-central/rev/51f5c75cfb6e https://hg.mozilla.org/mozilla-central/rev/f49e57b87a0b https://hg.mozilla.org/mozilla-central/rev/b12925eebad7 https://hg.mozilla.org/mozilla-central/rev/b8fb46941569 https://hg.mozilla.org/mozilla-central/rev/e1f009677c72 https://hg.mozilla.org/mozilla-central/rev/942fedc10653 https://hg.mozilla.org/mozilla-central/rev/3f4ac53f2225
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•