Open Bug 1337812 Opened 7 years ago Updated 2 years ago

CacheIR: consider passing GetElem/SetElem key as argument

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect

Tracking

()

Project Flags:
Performance Impact none

People

(Reporter: jandem, Unassigned)

References

(Blocks 1 open bug)

Details

GetPropIRGenerator and SetPropIRGenerator currently call {g,s}etElemKeyValueId to get the key's OperandId.

It might be nicer to pass it explicitly to the try* methods as Maybe<ValOperandId> and then pass it to maybeEmitIdGuard. Maybe<> because we don't have a key id when it's a GetProp/SetProp IC.
Priority: -- → P3
Whiteboard: [qf-]
Bug 1169745 adds similar get/set for super receiver and should be cleaned up at same time.
Performance Impact: --- → -
Whiteboard: [qf-]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.