1338016 - hfsplus task installs clang from yum

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

In bug 1337980, we're going to switch docker-based toolchain tasks to run-task, which drops privileges, which means yum can't be used to install clang.

We'll use tooltool instead (for now)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1338016 - Use clang from tooltool to build hfsplus.

Review commit: https://reviewboard.mozilla.org/r/110930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110930/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8835239 [details]
Bug 1338016 - Use clang from tooltool to build hfsplus.

https://reviewboard.mozilla.org/r/110930/#review112544

::: taskcluster/scripts/misc/build-hfsplus-linux.sh:12
(Diff revision 1)
>  HOME_DIR=$WORKSPACE/build
>  UPLOAD_DIR=$WORKSPACE/artifacts
>  
>  cd $HOME_DIR/src
>  
> +TOOLTOOL_MANIFEST=browser/config/tooltool-manifests/linux64/clang.manifest

Doesn't this mean the task will download other things like rustc that aren't needed? Creating a separate manifest file that just has clang should be fine too.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8835239 [details]
> Bug 1338016 - Use clang from tooltool to build hfsplus.
> 
> https://reviewboard.mozilla.org/r/110930/#review112544
> 
> ::: taskcluster/scripts/misc/build-hfsplus-linux.sh:12
> (Diff revision 1)
> >  HOME_DIR=$WORKSPACE/build
> >  UPLOAD_DIR=$WORKSPACE/artifacts
> >  
> >  cd $HOME_DIR/src
> >  
> > +TOOLTOOL_MANIFEST=browser/config/tooltool-manifests/linux64/clang.manifest
> 
> Doesn't this mean the task will download other things like rustc that aren't
> needed? Creating a separate manifest file that just has clang should be fine
> too.

That's what happens with other toolchain tasks already, so I wouldn't worry too much about it. They're not built very often, and bug 1313111 will allow finer-grained dependencies.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14f22ecd79f8
Use clang from tooltool to build hfsplus. r=mshal

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/14f22ecd79f8