1338715 - Remove Outlook Express import (since XP is no longer supported)

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1338715.patch

Richard made a start here ;-)

Comment 2

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/da132ad0ba30fbcf94638ceebc1a81149e2a61c1
Landed as bustage fix.

The complete removal of the OE import will follow.

Comment 3

[Jorg K (CEST = GMT+2)]

This isn't hard. One patch to remove mailnews/import/oexpress and a second one to remove any traces of oexpress:
https://dxr.mozilla.org/comm-central/search?q=regexp%3A%5Cboexpress%5Cb&redirect=false

Nice job for a rainy afternoon. If it compiles and no Outlook Express shows in any import, then it's right ;-)

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Remove the Outlook Express import files

Also when it's sunny here, I had some time to remove the files. ;-)

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Delete all traces to Outlook Express importer

Needed some more than your regex but it was a good start.

Not yet checked if there are tests for this importer.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8836321 [details] [diff] [review]
Remove the Outlook Express import files

Wasn't hard, was it ;-)

Comment 7

[Richard Marti (:Paenglab)]

Ah, there is test_oe_settings.js.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 8836322 [details] [diff] [review]
Delete all traces to Outlook Express importer

I didn't compile this, but I trust good Swiss quality work here ;-)
Meanwhile, German poor quality work can't be trusted. I'm referring to the terribly wrong DXR query which I posted in comment #3 which misses half the stuff that you found. Well done! Vertrauen ist gut, Kontrolle ist besser (Lenin) ;-)

Comment 9

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #7)
> Ah, there is test_oe_settings.js.
3rd patch is easiest. Also: mailnews/import/test/unit/xpcshell.ini

Comment 10

[Richard Marti (:Paenglab)]

Attachment: Remove the Outlook Express importer test

And now the test removal.

Comment 11

[Richard Marti (:Paenglab)]

Try to be sure
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=520811ac3e65e79cca15f1c4078c923c115e9bf2

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 8836323 [details] [diff] [review]
Remove the Outlook Express importer test

Thanks.

Comment 13

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/e9e57c02ee31e7e3b48be05295f58101203dec77
https://hg.mozilla.org/comm-central/rev/085844c49579d07fc010bfdd2ad07586af2eb522
https://hg.mozilla.org/comm-central/rev/bfdc0da4b7e4d38aecb573ce7dca5239c0818e84