1338807 - xpcshell tests fail on physical device with SELinux enabled

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Testing, defect, P5)

Description

[Jan Henning [:JanH]]

I've got a Moto G4 Play with Android 6.0.1 and despite being rooted xpcshell tests fail to run in the default configuration:

DMError: Error pushing file /home/jan/Mozilla/mozilla-central/objdir-droid/dist/bin/xpcshell -> /data/local/xpcb/xpcshell; output: ['[ 22%] /data/local/xpcb/xpcshell', '[ 44%] /data/local/xpcb/xpcshell', '[ 66%] /data/local/xpcb/xpcshell', '[ 89%] /data/local/xpcb/xpcshell', '[100%] /data/local/xpcb/xpcshell', "adb: error: failed to copy '/home/jan/Mozilla/mozilla-central/objdir-droid/dist/bin/xpcshell' to '/data/local/xpcb/xpcshell': Permission denied"]

Switching the SELinux mode to "permissive" makes things working again, so maybe the test harness could check the current SELinux mode, set it to "permissive" if necessary and restore the original state again afterwards.

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

adb_android.py tries to do this, but that's not used for most of our tests.

https://dxr.mozilla.org/mozilla-central/rev/7ef1e9abd296a8edc39b7efc8d637767ba2f77ed/testing/mozbase/mozdevice/mozdevice/adb_android.py#89

Comment 2

[Bob Clary [:bc] (inactive)]

Changing the SELinux mode isn't persistent so there is no need to restore really. It will be reset after the next boot anyway.

Comment 3

[Jan Henning [:JanH]]

Sure, but from a UX point of view rebooting is more of a hassle than just flipping it back on.

Comment 4

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Android xpcshell tests have been converted to adb_android.py, so this *might* just work now.

Comment 5

[Bob Clary [:bc] (inactive)]

gbrown: You mean the work I am doing for android hardware? Apart from the crash, maybe. :-)

Comment 6

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Heh. Right.

I was thinking that bug 1440714 has converted the xpcshell harness to use adb.py, which includes a setenforce call, so it should/might not have trouble pushing files to device, the way comment 0 was complaining about.

*But* we also recently discovered that xpcshell is crashing on Android 7 devices - bug 1451930. It works fine on Android 4.3. Not sure about other Android versions.

Comment 7

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.