1339032 - Update Intl legacy compromise semantics to match latest spec

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[André Bargull [:anba]]

The spec was updated to fix some minor issues, let's update our implementation accordingly.

Comment 1

[André Bargull [:anba]]

Attachment: bug1339032.patch

This updates the Intl legacy constructor semantics with the changes from https://github.com/tc39/ecma402/commit/7eb2c2b149ede6c192d9ba683191b7f8d7d05158 and https://github.com/tc39/ecma402/pull/127 (adds [[Description]] to the Intl fallback symbol).

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8836669 [details] [diff] [review]
bug1339032.patch

Review of attachment 8836669 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/Intl/DateTimeFormat/unwrapping.js
@@ -109,5 @@
>                  hasInstanceCalled = true;
>                  return true;
>              }, configurable: true
>          });
> -        let isUndefinedOrNull = thisValue !== undefined || thisValue !== null;

Erk.  This condition wasn't written correctly!  This variable would always have been true.

::: js/src/tests/Intl/NumberFormat/unwrapping.js
@@ -111,5 @@
>                  hasInstanceCalled = true;
>                  return true;
>              }, configurable: true
>          });
> -        let isUndefinedOrNull = thisValue !== undefined || thisValue !== null;

This was buggy too.

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8f68ef78915c4926b81b6f0f6b8ab5c1f068843

Comment 4

[André Bargull [:anba]]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> > -        let isUndefinedOrNull = thisValue !== undefined || thisValue !== null;
> 
> Erk.  This condition wasn't written correctly!  This variable would always
> have been true.

Psst, I tried to fix this one without attracting a lot of attention. :-)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0429b0b495da
Update Intl legacy constructor compromise semantics per the latest spec changes. r=Waldo

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0429b0b495da

Comment 7

[Jeff Walden [:Waldo]]

(In reply to André Bargull from comment #4)
> Psst, I tried to fix this one without attracting a lot of attention. :-)

I am wise to your ways.  :-)  The reviewer who let that in is clearly not to be trusted.