Closed
Bug 1339128
Opened 7 years ago
Closed 7 years ago
reference parent proxy by id
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
(Whiteboard: aes+)
Attachments
(1 file)
|
5.31 KB,
patch
|
eeejay
:
review+
gchang
:
approval-mozilla-aurora+
jcristau
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8836775 -
Flags: review?(eitan)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8836775 [details] [diff] [review] reference parent proxy by id Review of attachment 8836775 [details] [diff] [review]: ----------------------------------------------------------------- Looks good
Attachment #8836775 -
Flags: review?(eitan) → review+
Pushed by tsaunders@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/62f820d36c91 reference parent proxy by id r=eeejay
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/62f820d36c91
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•7 years ago
|
Whiteboard: aes+
|
||
Comment 5•7 years ago
|
||
Do we want to uplift this to Aurora since we know it fixed some crashes?
Assignee: nobody → tbsaunde+mozbugs
status-firefox53:
--- → affected
Flags: needinfo?(tbsaunde+mozbugs)
|
|
Assignee | |
Comment 6•7 years ago
|
||
Comment on attachment 8836775 [details] [diff] [review] reference parent proxy by id Approval Request Comment [Feature/Bug causing the regression]:unknown e10s and a11y related [User impact if declined]:crashes [Is this code covered by automated tests?]:yes, though none of them found the issues this fixes. [Has the fix been verified in Nightly?]:yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: [Is the change risky?]:low [Why is the change risky/not risky?]:fairly straight forward change. [String changes made/needed]:none
Flags: needinfo?(tbsaunde+mozbugs)
Attachment #8836775 -
Flags: approval-mozilla-beta?
Attachment #8836775 -
Flags: approval-mozilla-aurora?
|
||
Updated•7 years ago
|
status-firefox52:
--- → affected
|
|
||
Comment 7•7 years ago
|
||
Comment on attachment 8836775 [details] [diff] [review] reference parent proxy by id Fix possible crash. Aurora53+.
Attachment #8836775 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 8•7 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a6d3ee554e58
|
||
Comment 9•7 years ago
|
||
Comment on attachment 8836775 [details] [diff] [review] reference parent proxy by id AIUI this only affects people who force-enable e10s on 52? a- on that basis, as we're late in the cycle and I don't know if we'd have time to fix any fallout.
Attachment #8836775 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
|
|
||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•