1339596 - when clause doesn't work in tests.yml

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I have been trying to get 'when' to work in tests.yml.  Ifound that whenever we call filed_changed.check() it never invokes a check based on the 'when' clause I add to tests.yml.

In looking at this, it appears that my task label is missing the when syntax.

I found a comment that we lose the when syntax:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/task/transform.py#109

not sure if that applies- either way, I am not sure where in the taskgraph to look for the 'when', I have verified I have no 'when' data at this point:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/generator.py#189

I assume there is some way that an expert would know a more efficient way to debug this.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:dustin, when you have some time, could you help us figure this out?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

We're going to talk about this in vidyo tomorrow

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

I think we sorted this out on vidyo.  Joel's adding functionality to allow `when` to be used in tests.yml, and had missed a spot in implementing it.

Comment 4

[Greg Arndt [:garndt]]

I believe this has been fixed, and we're making it even better with the integration of moz.build stuff.  Is this something we need to keep open?