Closed
Bug 1339635
Opened 7 years ago
Closed 7 years ago
pingsender fails to build on Tier3 platforms
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
(Keywords: regression)
Attachments
(1 file)
$ ./mach build [...] Unified_cpp_pingsender0.o: In function `main': toolkit/components/telemetry/pingsender/Unified_cpp_pingsender0.cpp:(.text.main+0x130): undefined reference to `PingSender::Post(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)' /usr/bin/ld: Unified_cpp_pingsender0.o: relocation R_X86_64_PC32 against `_ZN10PingSender4PostERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEES8_' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value
After bug 969757 there's no more support for non-Unix systems besides Windows.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment on attachment 8837357 [details] Bug 1339635 - Unbreak build on Tier3 platforms after bug 1310703. https://reviewboard.mozilla.org/r/112508/#review113926 ::: toolkit/components/telemetry/pingsender/moz.build:24 (Diff revision 2) > UNIFIED_SOURCES += [ > 'pingsender_win.cpp', > ] > -elif CONFIG['OS_ARCH'] == 'Darwin' or CONFIG['OS_ARCH'] == 'Linux': > + > + OS_LIBS += [ > + 'wininet', Only pigsender_win.cpp uses wininet.dll. I don't think we support `OS_ARCH != OS_TARGET` on Windows, even less WINNT/Android. ;)
Updated•7 years ago
|
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8837357 [details] Bug 1339635 - Unbreak build on Tier3 platforms after bug 1310703. https://reviewboard.mozilla.org/r/112508/#review114596
Attachment #8837357 -
Flags: review?(ted) → review+
Keywords: checkin-needed
Updated•7 years ago
|
Assignee: nobody → jbeich
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/92756fb365fa Unbreak build on Tier3 platforms after bug 1310703. r=ted
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/92756fb365fa
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•