1339712 - TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_PingSender.js - Port bug 1310703 to C-C [Introduce the pingsender executable]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

First seen Tue Feb 14, 2017, 23:43:23:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=a7db0899f6a4eb581aca3e63668823a416111503

Looks like this is coming from bug 1310703.
https://hg.mozilla.org/mozilla-central/rev/ca283ec01ae1

Oh, perhaps it's as easy as adding this:

+@RESPATH@/crashreporter.ini
 
+; [ Ping Sender ]
+;
+@BINPATH@/pingsender@BIN_SUFFIX@
+

to package-manifest.in. I'll try that.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1339712-ping-sender.patch

Let's try this:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9c3716d6d9bfbb52220929769598a582e11f1206

Comment 4

[Jorg K (CEST = GMT+2)]

Richard, would you mind taking this on. Can we fix SM and IM at the same time?

My patch wasn't any good here, the try run said:
Error: package-manifest:652: Missing file(s): +bin/pingsender

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Pingsender.patch

app/macbuild/Contents/MacOS-files.in and installer/windows/nsis/shared.nsh needed also changes.

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks, Richard. Sorry about my poor quality patch. So for Linux there is no file that needs to change for the installer? Or maybe the distros do that. BTW, sorry about bug 1336804 whose patch is now most likely rotten.

I think this needs a try run to see whether it fixes the test failure:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=52b20190dc85c5f1d5832c625312aad6dd0c0acb

Comment 7

[Richard Marti (:Paenglab)]

Bug 1336804 isn't rotten. :-)

Comment 8

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/0dd78c1841a9e0f5a797a95dfa7383869eee504e

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8837484 [details] [diff] [review]
Pingsender.patch

Thanks!

Comment 10

[Frank-Rainer Grahl (:frg)]

This currently breaks my local suite compile. I think its only compiled when telemetry is on which SeaMonkey doesn't do. Need to investigate.

Comment 11

[Frank-Rainer Grahl (:frg)]

Posted too soon. Might just have needed a configure. Compile running.