1339797 - Using "Select all" option in Text selection menu in a text box dismisses the menu

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Kaartic Sivaraam]

The "Select all" option in the text selection menu dismissed the menu when it is used in a text input field.

Steps to reproduce:
1. Type some text in a text input field
2. Select a portion of it
3. Tap the "Select all" option from the Text selection menu

Expected results:
All text in text field is selected and the Text selection menu remains for using other option such as Cut, Copy etc.

Actual results:
All text in text field is selected but the Text selection menu is dismissed. This troubles the user as he not able to immediately cut/copy the selected text or paste text to replace the selected text.

Comment 1

[Jan Henning [:JanH]]

Still working fine on Release.

Comment 2

[Sorina Florean [:sflorean]]

Regression window:

Last good build: 2016-10-06
First bad build: 2016-10-07

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=777fb63db8de8d78b64b8141d1a998397275dd03&tochange=4b9944879c9a60a9aba4a744a7401bc38e0f39c4

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Regression in Fx 52

Bug 1235513 seems like a good candidate.

Comment 4

[Jan Henning [:JanH]]

Bug 1307252 is an even better one - verified by testing the relevant autoland builds.

Comment 5

[Marcia Knous [:marcia]]

Tracking 52/53/54 for this user facing regression.

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Thank you all for reporting this bug, and find the regression bug. I'll fix this.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets.

sHideCaretsForMouseInput is default to true on all platforms. When clicking
"SELECT ALL" on Fennec toolbar in <input>, AccessibleCaretManager will
receive SELECTALL_REASON with MOZ_SOURCE_TOUCH.

We should hide the carets only if the select-all reason is fired by
keyboard, not by touch.

Review commit: https://reviewboard.mozilla.org/r/113338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113338/

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8838413 [details]
Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets.

https://reviewboard.mozilla.org/r/113338/#review114818

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe7a3aa27666
Fix select-all events fired by touch incorrectly hide the carets. r=mtseng

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fe7a3aa27666

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora/Beta approval on this when you get a chance.

Comment 12

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8838413 [details]
Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1307252.
[User impact if declined]: If declined, after clicking "SELECT ALL" on the toolbar in a input field (like Google Search), the carets and toolbar will disappear.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: I've verified on Nightly (2017-02-18).
[Needs manual test from QE? If yes, steps to reproduce]: It would be good to double check by QE. See comment 0 for the steps.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low.
[Why is the change risky/not risky?]: Simple one line change, which affects only the select all logic.
[String changes made/needed]: None.

Comment 13

[Gerry Chang [:gchang]]

Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!

Comment 14

[Sorina Florean [:sflorean]]

Hi, 

Verified as fixed in latest Nightly build (2017-02-19);
Device: Nexus 9 (Android 7.1).
After clicking "SELECT ALL" on the toolbar in a input field, the carets and toolbar is still displayed.

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8838413 [details]
Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets.

Fix a UI issue and was verified. Aurora53+.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/86de27eb78e3

Comment 17

[Julien Cristau [:jcristau]]

Comment on attachment 8838413 [details]
Bug 1339797 - Fix select-all events fired by touch incorrectly hide the carets.

let's get this regression fix in the next beta build.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/396f58f0d63c

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/396f58f0d63c

Comment 20

[Sorina Florean [:sflorean]]

Verified as fixed in build 53.0a2 (2017-02-22);
Device: LG G4 (Android 6.0.1).