134016 - [PATCH] long anchor text in jprof output causes horizontal jumping

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Dave Morrison]

Many of the symbol names in jprof output are very long.  When these are used as
the text for HTML anchors, it results in very long link names.  As you click on
one link after another, the page scrolls horizontally as well as vertically,
which makes it very confusing.

Comment 1

[Dave Morrison]

Attachment: uses the timer hit count text as the anchor text - ends horizontal scrolling

A patch to be applied after the one attached to bug

http://bugzilla.mozilla.org/show_bug.cgi?id=132071

which uses different text for the anchor text.	It's not nearly as nice on the
eye as the original output (there are preceeding underscores, e.g.), but it
does produce a web page which doesn't flip back and forth horizontally and
confusingly as links are followed.

Comment 2

[Keyser Sose]

Marking NEW for patch loving./

Comment 3

[Boris Zbarsky [:bzbarsky]]

David, would you be a good person to review this patch?  Assuming it still applies?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Merged to tip

Unfortunately, this linkifies the leading spaces....

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140560 [details] [diff] [review]
Merged to tip

David, what do you think?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in.