134134 - need to flush custom headers to disk after we change them

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

need to flush custom headers to disk after we change them.

here's one reason we need this:

you can change them, use them in filters, write the filters to disk, crash 
later (before prefs written to disk) and then start back up.

the mismatch between filters and the prefs can cause bad problems.

the fix is easy:

Index: base/search/resources/content/CustomHeaders.js
===================================================================
RCS file: /cvsroot/mozilla/mailnews/base/search/resources/content/CustomHeaders.
js,v
retrieving revision 1.2
diff -u -w -r1.2 CustomHeaders.js
--- base/search/resources/content/CustomHeaders.js      27 Oct 2001 05:35:23 -00
00      1.2
+++ base/search/resources/content/CustomHeaders.js      29 Mar 2002 05:56:13 -00
00
@@ -76,6 +76,8 @@
   {
     var hdrs = gArrayHdrs.join(": ");
     gPrefs.setCharPref("mailnews.customHeaders", hdrs);
+    // flush this pref change to disk
+    gPrefs.savePrefFile(null);
   }
   window.close();
 }

Comment 1

[(not reading, please use [e-mail] instead)]

to reproduce this, change custom headers, crash (or kill) the application 
before we write prefs to disk.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: real patch, that works.

Comment 3

[Navin Gupta]

Comment on attachment 76706 [details] [diff] [review]
real patch, that works.

ok, I got your point. 
good catch, r=naving

Comment 4

[David :Bienvenu]

Comment on attachment 76706 [details] [diff] [review]
real patch, that works.

sr=bienvenu

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 76706 [details] [diff] [review]
real patch, that works.

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 6

[(not reading, please use [e-mail] instead)]

fixed on 3/31/2002

Comment 7

[laurel]

OK using june5 commercial branch: win98, linux rh6.2, mac OS 9.2