Closed Bug 1343460 Opened 7 years ago Closed 7 years ago

L10N as global variable

Categories

(DevTools :: Netmonitor, enhancement)

Product:
DevTools
Component:
Netmonitor
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

as mentioned in bug 1340464, we'd like convert L10N as global variable. Therefore we can remove L10N dependency from components

This contains 2 steps:
- dup webconsole related string into netmonitor strings, and remove webconsole strings dependency
- turn L10N as global variable and remove utils/l10n
I'm still concerned about this. What's benefit of moving L10N as a global variable? I'd prefer to leave it as it is.

const L10N = require("./utils/l10n"); makes more sense to understand where is the variable from, so everyone can look up the l10n.js quickly without finding where we inject it as a global.
Flags: qe-verify?
Whiteboard: [netmonitor] → [netmonitor] [triage]
We decided to close this at our triage meeting.

Honza
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Whiteboard: [netmonitor] [triage] → [netmonitor]
No longer blocks: netmonitor-html
Flags: qe-verify?
Whiteboard: [netmonitor]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.