1343620 - Make use of annotations.RootedPointers and JS_HAZ_ROOTED

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Steve Fink [:sfink] [:s:]]

mccr8 correctly pointed out that annotations.RootedPointers is never used. Which means that JS_HAZ_ROOTED does nothing.

isRootedTypeName really ought to consult that variable instead of just using weird hardcoded parsing. (Actually, it should probably check the variable first, then use weird hardcoded parsing for whatever is inconvenient to annotate in the source.)

Comment 1

[Karl Tomlinson (:karlt)]

Fixed by https://hg.mozilla.org/mozilla-central/rev/c0e228638fe4 ?

Comment 2

[Steve Fink [:sfink] [:s:]]

I guess so. And https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bde6d7478a28415eb743cc8d8c098a5ca8123b7 seems to say we can get rid of just about all of those out-of-source special cases now. (The TokenStream thing is different, sadly.)

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Use JS_HAZ_ROOTED everywhere instead of programmatic annotations

karlt is right.

Comment 4

[Paul Bone [:pbone]]

Comment on attachment 8984620 [details] [diff] [review]
Use JS_HAZ_ROOTED everywhere instead of programmatic annotations

Review of attachment 8984620 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I can tell thie makes sense.

Thanks, I also agree using JS_HAZ_ROOTED is better.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b15524c982e9
Use JS_HAZ_ROOTED everywhere instead of programmatic annotations, r=pbone

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b15524c982e9