Closed Bug 1343826 Opened 7 years ago Closed 2 years ago

Implement system time zone change observers

Categories

(Core :: Hardware Abstraction Layer (HAL), enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox54 --- wontfix
firefox103 --- fixed

People

(Reporter: anba, Assigned: leftmostcat)

References

Details

Attachments

(1 file)

Bug 1333197 was partly caused by missing support for system time zone change observers on all supported platforms [1]. We've added a workaround resp. requested a specification change for the ECMAScript Intl API, so the missing support doesn't lead to Talos regressions like bug 1314354, but ultimately it makes sense to get rid of this call [2], and instead use OS events to get notified when the system time zone was changed. 

[1] bug 1333197, comment #1, bug 1333197, comment #11
[2] http://searchfox.org/mozilla-central/rev/31b6089ce26fa76459642765115605d50a6c67b4/js/src/jscompartment.cpp#138-143
Forgot if I asked you already, but since we now have intl/locale/OSPreferences which is an intl related OS-specific code hooks that will have all the event listeners for reacting to system language changes, region preference changes etc.
Would it make sense to locate it there?
I don't mind where this functionality is implemented, as long as it is available. ;-)
Blocks: 1348916
Blocks: 1346211
Blocks: 895737
Blocks: 1198543
Blocks: 1300110
https://github.com/whatwg/html/pull/3047 will probably also require this functionality.
Blocks: 895742
Any news on this issue?

It also blocks https://bugzilla.mozilla.org/show_bug.cgi?id=1158733
Blocks: 1158733
No longer blocks: 1158733
Assignee: nobody → leftmostcat
Attachment #9277152 - Attachment description: WIP: Bug 1343826 - Add observer notifications on system timezone change. → Bug 1343826 - Add observer notifications on system timezone change. r=smaug
Status: NEW → ASSIGNED
Attachment #9277152 - Attachment description: Bug 1343826 - Add observer notifications on system timezone change. r=smaug → Bug 1343826 - Return updated timezone on system timezone change. r=smaug
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ec59aaac2c4
Return updated timezone on system timezone change. r=smaug,mstange,stransky,handyman
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: