1343837 - Remove obsolete chrome://global/content/findUtils.js

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, enhancement)

Description

[Florian Quèze [:florian]]

chrome://global/content/findUtils.js is reported as unreferenced by my test in bug 1316187.

I can't find any use of it in our tree, and dxr doesn't seem to show current usage of it in add-ons. SeaMonkey uses its own fork of this file. I think we can just remove it.

Comment 1

[Mark Banner (:standard8)]

I believe finddialog.xul, finddialog.dtd, finddialog.properties can be removed as well. Although finddialog.xul (and hence the .dtd and .properties) is used by SeaMonkey, so it should probably move those there.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1343837 - Remove find dialog resources from toolkit.

Review commit: https://reviewboard.mozilla.org/r/210082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210082/

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8939773 [details]
Bug 1343837 - Remove find dialog resources from toolkit.

https://reviewboard.mozilla.org/r/210082/#review215856

Looks good to me, thanks for the cleanup :-). This should land on inbound to avoid bitrot with bug 1356029.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c28fb6a2c61a
Remove find dialog resources from toolkit. r=florian

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/343de817418c
Remove find dialog resources from toolkit: Remove moz.build rules for removed files to fix build bustage. r=bustage-fix on a CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40ad3b14439f
Remove find dialog resources from toolkit: Remove another moz.build rule for removed files to fix build bustage. r=bustage-fix on a CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d63b4b5aab76
Remove find dialog resources from toolkit: Re-add moz.build rule for test files. DONTBUILD on a CLOSED TREE

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c28fb6a2c61a
https://hg.mozilla.org/mozilla-central/rev/343de817418c
https://hg.mozilla.org/mozilla-central/rev/40ad3b14439f
https://hg.mozilla.org/mozilla-central/rev/d63b4b5aab76