1343982 - Create minimal hotfix add-on in order to remove the websense hotfix add-on

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[Robert Strong (they/them - no direct email)]

We are using system add-ons for this and it would be a good thing to remove this so it is no longer changing the update url along with the system add-on.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[Robert Strong (they/them - no direct email)]

Not sure if this is the proper way to go but I went with the same compatibility info as the previous hotfix

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8843011 [details] [diff] [review]
patch

Review of attachment 8843011 [details] [diff] [review]:
-----------------------------------------------------------------

Also needs to add a brief description of this in the root README file.

::: v20170302.01/bootstrap.js
@@ +10,5 @@
> +  uninstallHotfix(data);
> +}
> +
> +function startup(data, reason) {
> +  uninstallHotfix(data);

In order to not cause any trouble to the AddonManager by calling uninstall on the same addon twice, I'd be more comfortable with just leaving this call and removing it from install().

::: v20170302.01/install.rdf
@@ +18,5 @@
> +      <Description>
> +        <!-- Firefox -->
> +        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
> +        <em:minVersion>39.0</em:minVersion>
> +        <em:maxVersion>47.*</em:maxVersion>

We bumped this manually on AMO to 48, so this should at least be 48.*.

But interestingly, right now it says on AMO that it's marked as compatible with 52.*.  ( https://addons.mozilla.org/en-US/firefox/addon/firefox-hotfix/versions/?page=1#version-20160826.01 ).  I wonder if this is a bug on AMO, as it shouldn't be bumping (I believe) an addon with strictCompatibility = true.

So now I don't know what to recommend about it, but I guess the best will be to use 52.*

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Comment 5

[Robert Strong (they/them - no direct email)]

Felipe, not sure what the next steps are for this. If you are willing to drive this in or provide me with the next steps I'd appreciate it. Thanks!

BTW: the AMO issue with this being compatible with 52 is an example of why I would like this gone... too many moving parts and edgecases.

Comment 6

[Robert Strong (they/them - no direct email)]

pushed to firefox-hotfixes
https://hg.mozilla.org/releases/firefox-hotfixes/rev/2655877d3168e1a4bad33d4dc0af243ac897ccc1

Comment 7

[Robert Strong (they/them - no direct email)]

Over irc Felipe said he will drive the remainder of this in a new bug. Thanks Felipe!