1344010 - MozReview doesn't show any indication for end-of-line character changes -- doesn't even display the changed lines

Status: RESOLVED INVALID

(MozReview Graveyard :: Review Board: DiffViewer, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Use MozReview's diff-viewer to view a patch that modifies line endings (e.g. changing from DOS-style to UNIX-style).  For example, here's a *2MB* diff which changes the line-ending for nearly every line in the affected file:
 https://reviewboard.mozilla.org/r/116740/diff/1

ACTUAL RESULTS:
MozReview's diff viewer shows only the last 8 lines of each file, and it doesn't show any changes, and it simply says "This file contains only whitespace changes."

EXPECTED RESULTS:
MozReview's diff viewer should show *all* of the changed lines, and it should highlight the fact that they're being changed somehow.

For reference, here's the raw-patch version of the diff linked above:
 https://reviewboard.mozilla.org/r/116740/diff/1/raw/
It shows "-"/ "+" lines for the (many) whitespace changes here.

Comment 1

[Daniel Holbert [:dholbert]]

As a motivator, this caused real confusion over on bug 1339298, where a rebase operation accidentally restored a bunch of DOS endline characters which had been removed on mozilla-central.

The extremely-deceptive diff is shown here -- look at the ContentPrefs.cpp change in particular:
 https://reviewboard.mozilla.org/r/112904/diff/3/

That looks like just a trivial 1-line insertion -- but really, the commit also touches **every line in that file**, as you can see from the raw diff:
 https://reviewboard.mozilla.org/r/112904/diff/3/raw/

Comment 2

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.