Closed
Bug 1344218
Opened 7 years ago
Closed 7 years ago
Remove holder and holderShape arguments from IonBuilder::testCommonGetterSetter
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
19.43 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
In bug 1328140 I'll add megamorphic getter/setter IC stubs. These stubs will only tell IonBuilder the getter/setter JSFunction, so we need to refactor IonBuilder::testCommonGetterSetter a bit to work with that. I renamed objectsHaveCommonPrototype to commonPrototypeWithGetterSetter and changed it to look for a common prototype with the getter/setter property, instead of looking for the holder object. The patch also restructures getPropTryCommonGetter and setPropTryCommonSetter a bit so we can easily add an extra else-if branch in bug 1328140.
Attachment #8843300 -
Flags: review?(bhackett1024)
|
||
Updated•7 years ago
|
Attachment #8843300 -
Flags: review?(bhackett1024) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a826a2d310b Rewrite IonBuilder::testCommonGetterSetter to search for the holder instead of taking it as argument. r=bhackett
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0a826a2d310b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•