1344297 - Turn off buildbot static analysis jobs on linux64 debug and macosx64 debug

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kartikaya Gupta (email:[e-mail])]

In bug 1264494 I added taskcluster jobs for the static-analysis builds for linux64 debug and macosx64 debug platforms. These jobs were previously running with buildbot, so now they are running with both. We can stop running them in buildbot once that change propagates around to the various branches.

Specific examples of the jobs can be seen at [1] and [2]. Note that it's only the *debug* jobs that are running on buildbot, the opt ones are already taskcluster'd.

Also note that once the buildbot version has been decommissioned, we can remove the block at [3] as we won't be exercising that mozconfig on a Darwin machine.

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e150eaff1f83e4e4a97d1e30c57d233859efe9cb&selectedJob=80883243
[2] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e150eaff1f83e4e4a97d1e30c57d233859efe9cb&selectedJob=80877978
[3] https://hg.mozilla.org/integration/autoland/file/fdf438735657/browser/config/mozconfigs/macosx64/debug-static-analysis#l5

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Bug 1264494 has made it to mozilla-central. So the old buildbot jobs can be turned off on inbound, autoland, and mozilla-central. Presumably once m-c merges to mozilla-aurora (sometime today or tomorrow) it can be turned off there as well.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Is this just a matter of ripping out all the -st-an stuff from https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py ? If so I can write a patch to do that. I have no idea how to test it though :/

Comment 3

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1344297.patch

Comment 4

[Sebastian Pacurar [:spacurar]]

Attachment: diff

I disabled static analysis builds for oak branch as well, because they already run on task cluster

Comment 5

[Kim Moir [:kmoir] ET]

Comment on attachment 8845476 [details] [diff] [review]
bug_1344297.patch

I think you can remove 

mc_gecko_version = BRANCHES['mozilla-central']['gecko_version']

too since it's not used by other stanzas.  

You also need a patch to remove the mozconfig stanza that kats mentioned in the original comment

[3] https://hg.mozilla.org/integration/autoland/file/fdf438735657/browser/config/mozconfigs/macosx64/debug-static-analysis#l5

This patch will have to land after the reconfig for the first patch, to ensure that all running jobs have completed.

Comment 6

[Alin Selagea [:aselagea]]

Comment on attachment 8845476 [details] [diff] [review]
bug_1344297.patch

https://hg.mozilla.org/build/buildbot-configs/rev/3c4f5edd47eb
https://hg.mozilla.org/build/buildbot-configs/rev/bf139a6884f9

Landed the patch with the above mentioned observation.

Comment 7

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1344297_mozconfig.patch

Comment 8

[Kartikaya Gupta (email:[e-mail])]

The buildbot changes seem to have taken effect and have stopped producing builds. AFAICT we should be able to land the mozconfig change and close out this bug.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7f6a6b8ee9c
Turn off buildbot static analysis jobs on linux64 debug and macosx64 debug, r=kmoir

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a7f6a6b8ee9c