1344309 - Regression "Highlight all" in findbar doesn't highlight any matches sometimes

Status: NEW

(Toolkit :: Find Toolbar, defect)

Description

[684sigma]

I have a problem with Firefox Beta 52. It doesn't happen in Firefox 51
Sometimes "Highlight all" function in findbar doesn't work.
It happens unpredictably, however, I noticed one specific scenario when it happens

1. Open http://example.org/ in a new tab
2. Open findbar, type "domain", enable "Highlight all", disable "Highlight all"
3. Open http://example.org/ in a new tab
4. Open findbar, enable "Highlight all"

Result: no matches highlighted

Expected: all 3 matches highlighted

Comment 1

[684sigma]

There's a mistake, it seems. Corrected scenario (I tested this) :

1. Open http://example.org/ in a new tab
2. Open findbar, type "domain", enable "Highlight all", disable "Highlight all"
3. Open http://example.org/ in a new tab
4. Open findbar, type "domain", enable "Highlight all"

1. Open http://example.org/ in a new tab
2. Open findbar, type "domain", enable "Highlight all", disable "Highlight all"
3. Open http://example.org/ in a new tab
4. Open findbar, enable "Highlight all", disable "Highlight all", enable "Highlight all"

I tested these 2 on Firefox 51, and it was OK. However, when I tried scenario from first comment, it was not completely OK. I think all mentioned scenarios were broken quite recently, I don't remember this bug on earlier versions of Firefox.

Comment 2

[Loic]

In FF54, the behaviour is a little bit different, after enabling "Highlight all" a 2nd time, instances of the keyword are not highlighted anymore.

Comment 3

[684sigma]

I checked Firefox ESR 45, there're NO issues at all. Is there a chance that this bug will be fixed on Firefox ESR 52?

Comment 4

[Loic]

It's probably not fixed because the find toolbar has been revamped since a few versions.

Comment 5

[Kacper Michajłow [:kasper93]]

I've also noticed strange behavior of "Highlight all" in nightly. 

1. Make sure "Highlight all" is enabled.
2. Search text
3. Everything is highlighted properly.
4. Disable "Highlight all"
5. Only current match is selected. But WITHOUT styling. Background dim and orange highlight is gone and we have normal blue highlight.
6. Things goes back to normal if we search again or move to next match.
7. But only if we change search text "Highlight all" can be enabled again, otherwise button doesn't do much. 


In short it is a little bit messy and hard to describe. But I'm sure if someone want to work on it it will be easy to reproduce for him :)

Comment 6

[Gerry Chang [:gchang]]

Too late for 51 and 52 will be released this week. Mark 51 won't fix.

Comment 7

[Nathan Froyd [:froydnj]]

Mike, can you take a look at this?  A regression that has stuck around for a couple of releases seems like a good candidate to fix.

Comment 8

[684sigma]

See comment 3, it says "checked Firefox ESR 45, there're NO issues at all". (My) issues appeared in later versions.
Bug status so far:

firefox beta 52     -  affected  (all scenarios broken)
firefox release 51  -  affected  (1 of 3 scenarios are broken)
firefox esr 45      -  unaffected

Comment 9

[Mike de Boer [:mikedeboer]]

OK, I'll take a look at this ASAP.

Comment 10

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 53, fix-optional for 54, minor carryover regression.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.