Closed
Bug 1344396
Opened 7 years ago
Closed 7 years ago
Build display lists directly instead of using an intermediate representation
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file)
|
66.26 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
This make us build display lists directly instead of through the now pointless IPC goop.
|
Assignee | |
Comment 1•7 years ago
|
||
This is a largely uninteresting patch that just uses the DisplayListBuilder directly. A wonderful cleanup patch will come after this. One of the more interesting pieces is the use of PushBuiltDisplayList. This is needed for handling empty transactions. See https://github.com/servo/webrender/pull/934 for more info. I'll take the first review that I can get.
Attachment #8843500 -
Flags: review?(rhunt)
Attachment #8843500 -
Flags: review?(nical.bugzilla)
Attachment #8843500 -
Flags: review?(bugmail)
|
||
Updated•7 years ago
|
Attachment #8843500 -
Attachment is patch: true
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8843500 [details] [diff] [review] Build the display lists directly Review of attachment 8843500 [details] [diff] [review]: ----------------------------------------------------------------- Remove the commented-out mCommands in WebRenderDisplayItemLayer.h. Also at some point we'll want to rename all the CreateWebRenderCommand functions but i guess we can wait until the dust settles.
Attachment #8843500 -
Flags: review?(rhunt)
Attachment #8843500 -
Flags: review?(nical.bugzilla)
Attachment #8843500 -
Flags: review?(bugmail)
Attachment #8843500 -
Flags: review+
|
|
||
Updated•7 years ago
|
Assignee: nobody → jmuizelaar
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/0d411df025f5 Build the display lists directly. r=kats
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0d411df025f5
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•