Closed
Bug 1344433
Opened 7 years ago
Closed 7 years ago
Cleanup gfx/gl library loading
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
(Whiteboard: gfx-noted)
Attachments
(6 files)
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
No description provided.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843624 [details] Bug 1344433 - Remove HasDXInterop(), but not HasDXInterop2(). - https://reviewboard.mozilla.org/r/117258/#review119044
Attachment #8843624 -
Flags: review?(dmu) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843625 [details] Bug 1344433 - Require GLX 1.4 (released 2005) - https://reviewboard.mozilla.org/r/117260/#review119048 ::: gfx/gl/GLContextProviderGLX.cpp:1320 (Diff revision 1) > return nullptr; > } > > // Handle slightly different signature between glXCreatePixmap and > // its pre-GLX-1.3 extension equivalent (though given the ABI, we > // might not need to). You may need to modify the comments here if you wanna upgrade to support GLX 1.4 only.
Attachment #8843625 -
Flags: review?(dmu) → review+
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843625 [details] Bug 1344433 - Require GLX 1.4 (released 2005) - https://reviewboard.mozilla.org/r/117260/#review119050 r=me for fixing the nits of the comments.
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843626 [details] Bug 1344433 - Reformat. - https://reviewboard.mozilla.org/r/117262/#review119098 LGTM
Attachment #8843626 -
Flags: review?(dmu) → review+
|
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843627 [details] Bug 1344433 - Use WRAP() macros. - https://reviewboard.mozilla.org/r/117264/#review119102 LGTM
Attachment #8843627 -
Flags: review?(dmu) → review+
|
|
||
Comment 11•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8843628 [details] Bug 1344433 - Fix ANGLE symbol loading. - https://reviewboard.mozilla.org/r/117266/#review119116
Attachment #8843628 -
Flags: review?(dmu) → review+
| Comment hidden (mozreview-request) |
|
||
Comment 13•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8844158 [details] Bug 1344433 - Allow GLX 1.3+glXGetProcAddressARB. - https://reviewboard.mozilla.org/r/117694/#review119392
Attachment #8844158 -
Flags: review?(jmuizelaar) → review+
|
||
Comment 14•7 years ago
|
||
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/96bb57eaa0e2 Remove HasDXInterop(), but not HasDXInterop2(). - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd77a2bc068 Require GLX 1.4 (released 2005) - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/a2624aa679c1 Reformat. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/b90bf52c69ea Use WRAP() macros. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/11ca2ac87fbd Fix ANGLE symbol loading. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/c726adc9b217 Allow GLX 1.3+glXGetProcAddressARB. - r=jrmuizel
|
||
Comment 15•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/96bb57eaa0e2 https://hg.mozilla.org/mozilla-central/rev/5dd77a2bc068 https://hg.mozilla.org/mozilla-central/rev/a2624aa679c1 https://hg.mozilla.org/mozilla-central/rev/b90bf52c69ea https://hg.mozilla.org/mozilla-central/rev/11ca2ac87fbd https://hg.mozilla.org/mozilla-central/rev/c726adc9b217
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•